-
Notifications
You must be signed in to change notification settings - Fork 3
chore(deps): june updates (part 2) #419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Bumps [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) from 6.2.6 to 6.3.4. - [Release notes](https://github.com/vitejs/vite/releases) - [Changelog](https://github.com/vitejs/vite/blob/main/packages/vite/CHANGELOG.md) - [Commits](https://github.com/vitejs/vite/commits/v6.3.4/packages/vite) --- updated-dependencies: - dependency-name: vite dependency-version: 6.3.4 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com>
WalkthroughThe changes update multiple dependencies in Changes
Sequence Diagram(s)sequenceDiagram
participant Developer
participant ESLint Config
participant TSESLint
Developer->>ESLint Config: Import configs from typescript-eslint
ESLint Config->>TSESLint: Compose recommended, strict, stylistic configs
TSESLint-->>ESLint Config: Return merged configuration
ESLint Config-->>Developer: Export composed ESLint config
Assessment against linked issues
Assessment against linked issues: Out-of-scope changes
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (2)
src/integrations/database/implementations/mongodb/MongoDb.ts (1)
256-271
: Return type now mismatches MongoDB 6.17’sSort
alias
Sort
is exported as a readonly record in the updated driver, but the method now returns a plain mutable object. Either:- #buildMongoSort(sort?: RecordSort): Sort + #buildMongoSort(sort?: RecordSort): Readonly<Record<string, 1 | -1>>or keep the current signature and add
return Object.freeze(mongoSort) as Sort;
.This keeps type-level guarantees and avoids accidental mutation later on.
eslint.config.js (1)
42-43
: Re-evaluating disabled rulesTurning off
•@typescript-eslint/no-non-null-assertion
•@typescript-eslint/no-extraneous-class
removes two of the stricter safety nets. If they are only noisy in specific spots, prefer inline
// eslint-disable-next-line
comments to keep the global rule enabled elsewhere.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
package-lock.json
is excluded by!**/package-lock.json
📒 Files selected for processing (3)
eslint.config.js
(3 hunks)package.json
(2 hunks)src/integrations/database/implementations/mongodb/MongoDb.ts
(1 hunks)
🔇 Additional comments (2)
package.json (1)
43-52
: Run a full test / smoke build after the dependency bumps
mongodb 6.17
,openid-client 6.5.x
,react-router-dom 7.6.x
, etc. all ship typing tweaks and a few behavioural changes. Regeneratepackage-lock
/pnpm-lock
, rebuild and run the e2e/contract tests to catch any surprises.eslint.config.js (1)
7-13
: Double-check thetseslint.config( … )
invocationThe helper expects each argument to be a flat-config object.
If any of the spread configs mutate shared objects it may lead to unexpected side-effects. Quick test:npx eslint --print-config file.ts
and confirm final ruleset is correct.
The @estlint/js dependency is used, the eslint isn't anymore.
|
Fixes #409
Changes proposed in this pull request:
@MaskingTechnology/comify
Summary by CodeRabbit