Skip to content

Conversation

basmasking
Copy link
Member

@basmasking basmasking commented Jun 13, 2025

Fixes #409

Changes proposed in this pull request:

  • updated dependencies
  • updated eslint configs to work with the latest version
  • Sort type from mongo is now read-only. Re-typed our sort object to a matching type.

@MaskingTechnology/comify

Summary by CodeRabbit

  • Chores
    • Updated several dependencies to their latest versions for improved stability and compatibility.
    • Refactored the ESLint configuration for better maintainability and alignment with recommended practices.
  • Refactor
    • Improved type annotations in the MongoDB integration for clearer internal code structure.

@basmasking basmasking requested a review from petermasking June 13, 2025 09:46
@basmasking basmasking linked an issue Jun 13, 2025 that may be closed by this pull request
Copy link

coderabbitai bot commented Jun 13, 2025

Walkthrough

The changes update multiple dependencies in package.json, refactor the ESLint configuration to use the new tseslint.config API, and adjust a type annotation in a MongoDB integration. The ESLint config now composes recommended and stylistic rulesets and disables two specific TypeScript rules. No functional code logic is altered.

Changes

Files/Groups Change Summary
eslint.config.js Refactored to use tseslint.config for composing configs; updated plugin import; disabled two TS rules; removed explicit plugin registration.
package.json Updated several dependencies and devDependencies; removed @typescript-eslint/eslint-plugin.
src/integrations/database/implementations/mongodb/MongoDb.ts Changed local type annotation in #buildMongoSort from Sort to Record<string, 1 | -1>.

Sequence Diagram(s)

sequenceDiagram
    participant Developer
    participant ESLint Config
    participant TSESLint

    Developer->>ESLint Config: Import configs from typescript-eslint
    ESLint Config->>TSESLint: Compose recommended, strict, stylistic configs
    TSESLint-->>ESLint Config: Return merged configuration
    ESLint Config-->>Developer: Export composed ESLint config
Loading

Assessment against linked issues

Objective Addressed Explanation
Update dependencies as per May updates (#409)

Assessment against linked issues: Out-of-scope changes

Code Change Explanation
Refactor ESLint config structure and plugin import (eslint.config.js) The ESLint config refactor goes beyond dependency version updates and was not explicitly requested in the linked issue.
Change internal type annotation in MongoDb.ts (#buildMongoSort method) Adjusting type annotations is unrelated to dependency updates and not mentioned in the objectives.

Poem

In May, the carrots grew quite tall,
Dependencies got updates, one and all!
ESLint learned some brand new tricks,
Mongo’s sort type got a fix.
With every hop, the code’s more neat—
Another update, another treat!
🥕✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3d6ce27 and fb80065.

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (1)
  • package.json (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • package.json
⏰ Context from checks skipped due to timeout of 90000ms (2)
  • GitHub Check: build (lts/*)
  • GitHub Check: Analyze (javascript)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (2)
src/integrations/database/implementations/mongodb/MongoDb.ts (1)

256-271: Return type now mismatches MongoDB 6.17’s Sort alias

Sort is exported as a readonly record in the updated driver, but the method now returns a plain mutable object. Either:

- #buildMongoSort(sort?: RecordSort): Sort
+ #buildMongoSort(sort?: RecordSort): Readonly<Record<string, 1 | -1>>

or keep the current signature and add return Object.freeze(mongoSort) as Sort;.

This keeps type-level guarantees and avoids accidental mutation later on.

eslint.config.js (1)

42-43: Re-evaluating disabled rules

Turning off
@typescript-eslint/no-non-null-assertion
@typescript-eslint/no-extraneous-class

removes two of the stricter safety nets. If they are only noisy in specific spots, prefer inline // eslint-disable-next-line comments to keep the global rule enabled elsewhere.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4622685 and 3d6ce27.

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (3)
  • eslint.config.js (3 hunks)
  • package.json (2 hunks)
  • src/integrations/database/implementations/mongodb/MongoDb.ts (1 hunks)
🔇 Additional comments (2)
package.json (1)

43-52: Run a full test / smoke build after the dependency bumps

mongodb 6.17, openid-client 6.5.x, react-router-dom 7.6.x, etc. all ship typing tweaks and a few behavioural changes. Regenerate package-lock/pnpm-lock, rebuild and run the e2e/contract tests to catch any surprises.

eslint.config.js (1)

7-13: Double-check the tseslint.config( … ) invocation

The helper expects each argument to be a flat-config object.
If any of the spread configs mutate shared objects it may lead to unexpected side-effects. Quick test: npx eslint --print-config file.ts and confirm final ruleset is correct.

The @estlint/js dependency is used, the eslint isn't anymore.
Copy link

@basmasking basmasking changed the title chore: may dependency updates chore(deps): may dependency updates Jun 13, 2025
@basmasking basmasking changed the title chore(deps): may dependency updates chore(deps): may updates Jun 13, 2025
@basmasking basmasking changed the title chore(deps): may updates chore(deps): june updates Jun 13, 2025
@petermasking petermasking merged commit 663b65a into main Jun 13, 2025
7 checks passed
@basmasking basmasking changed the title chore(deps): june updates chore(deps): june updates (part 2) Jun 13, 2025
@petermasking petermasking deleted the 409-may-dependency-updates branch June 13, 2025 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

May dependency updates

2 participants