chore(deps): july updates #425
Conversation
WalkthroughThis change updates several development and optional dependencies in the Changes
Assessment against linked issues
Possibly related PRs
Suggested reviewers
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
package.json (2)
60-61: Ensure@vitejs/plugin-react@4.6+@vitest/coverage-v8@3.2stay in sync with Vite/Vitest majorsBoth packages track Vite/Vitest internals closely.
Before merging, runvitest runandvite buildlocally — mismatched versions tend to fail
with opaque “plugin hook” errors.If issues arise, pin them to the exact versions that Vite 7’s release notes recommend.
77-77: Rollup 4 native binary bump – verify build images
@rollup/rollup-linux-x64-gnu@4.44.1bundles Glibc-linked binaries.
If your CI or Docker images use musl/alpine you’ll silently fall back to JS builds,
increasing build times.Consider adding the alpine flavour (
@rollup/rollup-linux-x64-musl) or switching to the
new universal@rollup/rolluppackage to avoid surprises.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (1)
package.json(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: build (lts/*)
🔇 Additional comments (3)
package.json (3)
71-72: Major upgrade to Vite 7 – double-check plugin ecosystem
vite@7is still in beta/RC and carries breaking changes (Rollup 4 bump, new HMR client,
CSS fallback removal, etc.). Confirm that:
vite-plugin-pwa@1.0.1@jitar/plugin-vite@0.9.3- any local
vite.config.tshookscompile & serve without warnings.
Run
npm run devand iterate through core routes to catch runtime regressions.
55-55: Specify and Align Your Node Runtime VersionYour tsconfig (tsconfig.base.json: line 3) targets “ESNext”, but package.json doesn’t declare an
engines.nodeversion. Without a pinned Node baseline, using@types/node@24.0.10may introduce type mismatches if CI/production run on an older LTS (e.g. Node 18 or 20).Please verify and update accordingly:
• Add or confirm the
engines.nodefield in package.json with your minimum supported Node version
• Ensure your CI/workflow definitions (e.g. in .github/workflows) install that same Node version
• If you intend to support older Node versions, consider downgrading to a matching@types/noderelease
64-70: No downgrade needed: current plugins support ESLint 9The peer dependencies for both plugins already allow ESLint 9:
@typescript-eslint/eslint-plugin@8.35.1:eslint: '^8.57.0 || ^9.0.0'eslint-plugin-sonarjs@3.0.4:eslint: '^8.0.0 || ^9.0.0'You can safely keep
@eslint/js@9.30.1.Likely an incorrect or invalid review comment.
2 participants
Fixes #424
@MaskingTechnology/comify
Summary by CodeRabbit