Start to reduce/refactor arithmetic ... #889
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove stuff from mathics.builtin.arithmetic that does not belong there: * _MPMathFunction -> MPMathFunction and move to mathics.buitin.base * _MPMathMultiFunction -> MPMathFunction and move to mathics.builtin.base * Abs, Piecewise, RealAbs, RealSign, Sign moved to numeric to follow WMA organization better The corresponding eval routines will be gone over in another PR. This one is already large. Url's gone over to make this not exceed standard line limit. Note that the formatting has been gone over to follow the existing pattern that we have been using. cythonization in mathics.builtin class files removed. It is not clear this has benefit in modern Pythons, especially in this kind of builtin function and all of this needs to be retested if not rethought.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove stuff from
mathics.builtin.arithmeticthat does not belong there:_MPMathFunction->MPMathFunctionand move tomathics.buitin.base_MPMathMultiFunction->MPMathFunctionand move tomathics.builtin.baseAbs,Piecewise,RealAbs,RealSign,Signmoved tomathics.builtin.numericto follow WMA organization betterThe corresponding
eval_routines will be gone over in another PR. This one is already large.Url's gone over to make this not exceed standard line limit. Note that the formatting has been gone over to follow the existing pattern that we have been using.
cythonization in mathics.builtin class files removed. It is not clear this has benefit in modern Pythons, especially in this kind of builtin function and all of this needs to be retested if not rethought.