feat: keyring controller error #7498
Merged
+701
−138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
ccharly
reviewed
Jan 7, 2026
| * Additional context data associated with the error. | ||
| * Useful for debugging and error reporting. | ||
| */ | ||
| data?: Record<string, unknown>; |
Contributor
There was a problem hiding this comment.
WDYT about using context instead?
Suggested change
| data?: Record<string, unknown>; | |
| context?: Record<string, unknown>; |
ccharly
reviewed
Jan 8, 2026
Co-authored-by: Charly Chevalier <charly.chevalier@consensys.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
This PR introduces a new KeyringController error that will properly propagate errors from the keyring instances.
References
Checklist
Note
Introduces a unified error type and updates error handling across the keyring controller.
KeyringControllerErrorwith code/context/cause support and JSON/string serialization (src/errors.ts), export viasrc/index.tsKeyringControllerErrorMessageand refactorKeyringControllerto throwKeyringControllerError(wrapping keyring errors) instead of generic errors; normalize many error sites and messagesKeyringControllerErrorMessageWritten by Cursor Bugbot for commit dcde33f. This will update automatically on new commits. Configure here.