feat: Attach metadata when submitting a revocation to the permission provider snap #7503
Conversation
V00D00-child
changed the title
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
jeffsmale90
left a comment
jeffsmale90
left a comment
There was a problem hiding this comment.
Should we also add revocationMetadata to StoredGatorPermission (and as per my comments on the related PR, perhaps remove the isRevoked flag?
This would probably require some changes to how we load the permission from storage also, but IMO worthwhile,
packages/gator-permissions-controller/src/GatorPermissionsController.ts
Outdated
Show resolved
Hide resolved
packages/gator-permissions-controller/src/GatorPermissionsController.ts
Outdated
Show resolved
Hide resolved
jeffsmale90
left a comment
jeffsmale90
left a comment
There was a problem hiding this comment.
Looks good to me!
One nit that I'm not especially concerned about, but might be a nice tidy up.
I am keen to understand the behaviour regarding failed transactions - we definitely don't want to be marking a permission as revoked if the transaction has failed.
| // Handle confirmed transaction - submit revocation | ||
| handlers.confirmed = (transactionMeta) => { | ||
| if (transactionMeta.id === txId) { | ||
| controllerLog('Transaction confirmed, submitting revocation', { |
There was a problem hiding this comment.
not strictly related to this PR - but do we need to check transactionMeta.status here?
When a transaction is confirmed, do we explicitly guard against failed transactions?
Explanation
This PR extends the
GatorPermissionsControllerto allow attaching metadata when submitting a revocation to the permission provider snap. Metadata includes:The block timestampReferences
Requires(gator snap): feat: Store metadata when revoking a permission
Required by(MM client): chore: Bump @metamask/gator-permissions-controller to 0.9.0
Checklist
Note
Introduces metadata attachment for permission revocations and updates API accordingly.
RevocationParamsnow requiresrevocationMetadata; controller parsestransactionConfirmedto includetxHashand forwards it topermissionsProvider_submitRevocationpermissionsProvider_getGrantedPermissionsrevocationMetadataand validate new behavior; exportsRevocationMetadata; changelog updatedWritten by Cursor Bugbot for commit 6b0625d. This will update automatically on new commits. Configure here.