feat: fake the rwaData returned from backend to make sure it work for mobile frontend. #7548
+117
−87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@metamaskbot publish-preview |
Contributor
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
Contributor
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
Contributor
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
dawnseeker8
commented
Jan 9, 2026
| }, | ||
| "packages/assets-controllers/src/TokenListController.ts": { | ||
| "@typescript-eslint/explicit-function-return-type": { | ||
| "count": 6 |
Contributor
Author
There was a problem hiding this comment.
This change will fix the lint complaining about --prune-suppressions paratmeter, but when we put that parameter to run yarn lint it still complain. the only way is to change the count here to pass the error, if your guys know some better way to fix this issue, i am happy to change it back here.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| (elm) => | ||
| Boolean(elm.aggregators.includes('lineaTeam')) || | ||
| elm.aggregators.length >= 3, | ||
| elm.aggregators.includes('lineaTeam') ?? elm.aggregators.length >= 3, |
There was a problem hiding this comment.
Nullish coalescing breaks token filter logic
High Severity
The filter logic for Linea Mainnet tokens changed from || (logical OR) to ?? (nullish coalescing). The includes() method always returns a boolean (true or false), never null or undefined. Since ?? only evaluates the right-hand side when the left is null/undefined, the condition elm.aggregators.length >= 3 will never be evaluated. Tokens without 'lineaTeam' but with 3+ aggregators will be incorrectly filtered out, breaking the intended behavior documented in the changelog as "lineaTeam aggregator OR more than 3 aggregators".
| minMarketCap, | ||
| maxMarketCap, | ||
| excludeLabels, | ||
| includeRwaData, |
There was a problem hiding this comment.
API parameter documented but silently ignored
Medium Severity
The getTrendingTokens function's type definition still includes includeRwaData?: boolean at line 281, and the CHANGELOG documents this as an optional parameter. However, includeRwaData is no longer destructured from the function parameters (lines 263-271), meaning any value passed by callers is silently ignored. The parameter is now hardcoded to 'true' at line 109. Callers expecting to control RWA data inclusion will experience unexpected behavior.
Additional Locations (1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is draft PR to fake the backend returned to provide rwaData metadata to mobile frontend.
Explanation
References
Checklist
Note
Introduces optional
rwaDataacross token types and ensures it is fetched and stored throughout the assets stack.includeRwaData=trueto token-service URLs (/tokens,/token,/tokens/search,/v3/tokens/trending), refactors search URL helper, and adjusts headers handlingTokenListToken,Token(rates), and asset selector items to includerwaData; plumbsrwaDatathroughTokensController(add/import/detected),TokenDetectionController(RPC/WS/polling flows), and caches inTokenListControllervalidatorsschema updated to acceptrwaDataWritten by Cursor Bugbot for commit ffabbd2. This will update automatically on new commits. Configure here.