feat(transaction-pay-controller): max quotes #7562
Open
+271
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add messenger action and method. Update trade type and amount. Update totals.
Remove getTransactionData util.
matthewwalsh0
changed the title
Member
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
packages/transaction-pay-controller/src/strategy/bridge/bridge-quotes.ts
Show resolved
Hide resolved
packages/transaction-pay-controller/src/strategy/bridge/bridge-quotes.ts
Show resolved
Hide resolved
Member
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Support Relay quotes using the entire payment token balance, by using the
EXACT_INPUTtrade type, rather than the standardEXPECTED_OUTPUT.Enabled via the new
setIsMaxAmountpublic method and messenger action.References
Related to #6498
Checklist
Note
Introduces max-amount quotes in Transaction Pay, enabling relay quotes that consume the full payment token balance and updating totals/metadata accordingly.
setIsMaxAmountaction/method andisMaxAmountinTransactionData; triggers source amount recalculation and quote refreshEXACT_INPUTtrade type whenisMaxAmountis true; forbids included transactions in this mode; request/response types extended to support thistargetAmount; totals calculation updated to usetargetAmountwhenisMaxAmountis selectedmetamaskPaymetadata with newtargetFiat; adds optionaltargetFiattoMetamaskPayMetadataintransaction-controllerWritten by Cursor Bugbot for commit 9462ebb. This will update automatically on new commits. Configure here.