I/O revision II 文本提取补充实现 #3
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
请直接看https://github.com/MewX/cross-channel_chinese-localization_project/pull/3/commits/ca51e633104488cefd4a3618b592203cb366b557 |
|
一般来说提交pull request直接新建一个branch，然后只做想要merge 的改动在这个branch，自己的改动可以放在其他branch。 我看了下后面的提交，很多临时文件和输入文件都提交进来了，有点messy，没法merge。 你要不要试试新建一个branch，然后 如果不想练手的话，我可以直接代劳 |
MewX
approved these changes
Aug 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
文本的结尾判断并没有加边界检测，会将三个资源文件的一小部分误提取，不过好像影响不大，就不管了