Skip to content

Conversation

@diksha-hop
Copy link

updated help upgrade command

@prmerger-automator
Copy link
Contributor

@diksha-hop : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change.

@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit 1434853:

✅ Validation status: passed

File Status Preview URL Details
articles/energy-data-services/includes/how-to/how-to-deploy-gcz/deploy-gcz-on-aks.md ✅Succeeded

For more details, please refer to the build report.

@jorchiu
Copy link

jorchiu commented Oct 24, 2025

```bash
helm upgrade -i $CHART . -n $NAMESPACE -f osdu_gcz_custom_values.yaml --set-file global.provider.configLoaderJs="../../../../gcz-provider/gcz-provider-core/config/configLoader.js"
helm upgrade -i "$RELEASE_CHART_NAME" . -n "$NAMESPACE" -f osdu_gcz_custom_values.yaml \
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RELEASE_CHART_NAME is undefined.

The community version is different:
image

@ShannonLeavitt
Copy link
Contributor

@EirikHaughom

Can you review the proposed changes?

IMPORTANT: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator bot added the aq-pr-triaged tracking label for the PR review team label Oct 24, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Helm upgrade command in the GCZ deployment documentation to improve readability and consistency. The command is refactored to use quoted variables and split across multiple lines for better clarity.

Key Changes:

  • Modified the Helm upgrade command to use quoted environment variables ("$RELEASE_CHART_NAME" and "$NAMESPACE") instead of an unquoted variable reference
  • Split the command across two lines for improved readability

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

```bash
helm upgrade -i $CHART . -n $NAMESPACE -f osdu_gcz_custom_values.yaml --set-file global.provider.configLoaderJs="../../../../gcz-provider/gcz-provider-core/config/configLoader.js"
helm upgrade -i "$RELEASE_CHART_NAME" . -n "$NAMESPACE" -f osdu_gcz_custom_values.yaml \
Copy link

Copilot AI Oct 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The variable $RELEASE_CHART_NAME is introduced in this command but was not used previously (the original command used $CHART). This documentation should either define $RELEASE_CHART_NAME before this step or continue using $CHART for consistency with the variable that was presumably defined earlier in the documentation.

Suggested change
helm upgrade -i "$RELEASE_CHART_NAME" . -n "$NAMESPACE" -f osdu_gcz_custom_values.yaml \
helm upgrade -i "$CHART" . -n "$NAMESPACE" -f osdu_gcz_custom_values.yaml \

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants