Skip to content

master #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

master #1

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9f7a151
included VPN network in network check
sdzshn3 Jun 22, 2020
fefff06
suppressed deprecation warning for ConnectivityManager
sdzshn3 Jun 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions app/src/main/java/com/mindorks/framework/mvvm/utils/NetworkHelper.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ class NetworkHelper @Inject constructor(@ApplicationContext private val context:
activeNetwork.hasTransport(NetworkCapabilities.TRANSPORT_WIFI) -> true
activeNetwork.hasTransport(NetworkCapabilities.TRANSPORT_CELLULAR) -> true
activeNetwork.hasTransport(NetworkCapabilities.TRANSPORT_ETHERNET) -> true
activeNetwork.hasTransport(NetworkCapabilities.TRANSPORT_VPN) -> true
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might not so important in sample project. But it's a must in real apps because user expects app to work normal while using VPN.

else -> false
}
} else {
Expand All @@ -32,6 +33,7 @@ class NetworkHelper @Inject constructor(@ApplicationContext private val context:
ConnectivityManager.TYPE_WIFI -> true
ConnectivityManager.TYPE_MOBILE -> true
ConnectivityManager.TYPE_ETHERNET -> true
ConnectivityManager.TYPE_VPN -> true
else -> false
}

Expand Down