3.5 - ToolExecSpec/Operations #27
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is mostly a GradleUtils Shared change, but was large enough to warrant a minor version bump. This also includes some deprecations and (binary compatible) structural changes to GradleUtils itself. Co-authored-by: LexManos <LexManos@gmail.com>
Jonathing
force-pushed
the
feat/jonathing/3.5/tool-exec-operations
branch
from
705e65a to
947a9cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
ToolExecSpecandToolExecOperations.ToolExecSpecis designed to be a nested task input property to remove additional clutter in tasks that need to use the GradleUtils Shared tool system to execute tools.ToolExecOperationswill be an abstract class, similar toExecOperationsthat is instantiated through anObjectFactoryinstead of through a service injection. The idea is for it to behave similarly to it, and it is whatToolExecSpecwill likely end up using.The purpose of this is to remove need to depend on
ToolExecBasefor various tasks, although it will continue to exist for sake of convenience.