Skip to content

Flow Node Validation enhancements #298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: 5.x
Choose a base branch
from
Open

Flow Node Validation enhancements #298

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e7366c0
Flow Node Validation improvements
Numblaze Jun 15, 2025
e9f9476
Moved validation code from UFlowNode to UFlowNodeBase
Numblaze Jun 16, 2025
39f60ec
Flow Node AddOns validation handled in UFlowAsset::ValidateAsset
Numblaze Jun 16, 2025
a004df2
Merge branch '5.x' into 5.x
MothDoctor Aug 20, 2025
50ea099
Update FlowNodeBase.cpp
MothDoctor Aug 20, 2025
14f030e
Added parent node support for Flow Node AddOns
Numblaze Oct 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions Source/Flow/Private/FlowAsset.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,10 +122,8 @@ EDataValidationResult UFlowAsset::ValidateAsset(FFlowMessageLog& MessageLog)
}

Node.Value->ValidationLog.Messages.Empty();
if (Node.Value->ValidateNode() == EDataValidationResult::Invalid)
{
MessageLog.Messages.Append(Node.Value->ValidationLog.Messages);
}
Node.Value->ValidateNode();
MessageLog.Messages.Append(Node.Value->ValidationLog.Messages);
}
else
{
Expand All @@ -134,7 +132,17 @@ EDataValidationResult UFlowAsset::ValidateAsset(FFlowMessageLog& MessageLog)
}
}

return MessageLog.Messages.Num() > 0 ? EDataValidationResult::Invalid : EDataValidationResult::Valid;
// if at least one error has been has been logged : mark the asset as invalid
for (const TSharedRef<FTokenizedMessage>& Msg : MessageLog.Messages)
{
if (Msg->GetSeverity() == EMessageSeverity::Error)
{
return EDataValidationResult::Invalid;
}
}

// otherwise, the asset is considered valid (even with warnings or notes)
return EDataValidationResult::Valid;
}

bool UFlowAsset::IsNodeOrAddOnClassAllowed(const UClass* FlowNodeOrAddOnClass, FText* OutOptionalFailureReason) const
Expand Down
31 changes: 31 additions & 0 deletions Source/Flow/Private/Nodes/FlowNode.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,8 +72,39 @@ void UFlowNode::PostLoad()
FixNode(nullptr);
}

EDataValidationResult UFlowNode::ValidateNode()
{
if (GetClass()->IsFunctionImplementedInScript(GET_FUNCTION_NAME_CHECKED(UFlowNode, K2_ValidateNode)))
{
return K2_ValidateNode();
}

return EDataValidationResult::NotValidated;
}

#endif

void UFlowNode::LogValidationError(const FString& Message)
{
#if WITH_EDITOR
ValidationLog.Error<UFlowNode>(*Message, this);
#endif
}

void UFlowNode::LogValidationWarning(const FString& Message)
{
#if WITH_EDITOR
ValidationLog.Warning<UFlowNode>(*Message, this);
#endif
}

void UFlowNode::LogValidationNote(const FString& Message)
{
#if WITH_EDITOR
ValidationLog.Note<UFlowNode>(*Message, this);
#endif
}

bool UFlowNode::IsSupportedInputPinName(const FName& PinName) const
{
const FFlowPin* InputPin = FindFlowPinByName(PinName, InputPins);
Expand Down
22 changes: 20 additions & 2 deletions Source/Flow/Public/Nodes/FlowNode.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,10 +59,28 @@ class FLOW_API UFlowNode
virtual void PostLoad() override;
// --

virtual EDataValidationResult ValidateNode() { return EDataValidationResult::NotValidated; }

virtual EDataValidationResult ValidateNode();
#endif

// Flow Node Validation : blueprint compatibility

// Optional validation override for Blueprints
UFUNCTION(BlueprintImplementableEvent, Category = "FlowNode|Validation", meta = (DisplayName = "Validate Node"))
EDataValidationResult K2_ValidateNode();

// Log validation error (editor-only)
UFUNCTION(BlueprintCallable, Category = "FlowNode|Validation")
Copy link
Contributor

@MaksymKapelianovych MaksymKapelianovych Jun 15, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add meta = (DevelopmentOnly) to these functions?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done !

void LogValidationError(const FString& Message);

// Log validation warning (editor-only)
UFUNCTION(BlueprintCallable, Category = "FlowNode|Validation")
void LogValidationWarning(const FString& Message);

// Log validation note (editor-only)
UFUNCTION(BlueprintCallable, Category = "FlowNode|Validation")
void LogValidationNote(const FString& Message);
// --

// Inherits Guid after graph node
UPROPERTY()
FGuid NodeGuid;
Expand Down