Skip to content

Inventory UI fixes #712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

BenjaminAmos
Copy link
Contributor

Description

This pull request fixes various issues encountered when testing the inventory UI a bit more thoroughly:

  • Fixes a crash when dropping the player's shield.
  • Fixes a crash when using keyboard navigation after all items are sold.
  • Changes highlight behaviour to target the nearest item after the currently highlighted item is removed.

Testing

  • Start a new game
  • Open the inventory screen and drop each of your items one-by-one.
  • When an item is dropped, the highlight cursor should move to the next item along (or the previous item, for the last item).
  • The game should not crash when you drop your shield.
  • Additionally, follow the instructions in list highlight crashing program #711 and ensure that the game does not crash.

Notes

This fixes #711.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

list highlight crashing program
1 participant