Add tests and optimize code #52
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![google-labs-jules[bot]](https://avatars.githubusercontent.com/in/842251?s=60&v=4){kind=small}
- Add PHPUnit for testing and PHPMD for code quality analysis. - Add tests for the main API endpoints. - Refactor the core classes to improve code quality and testability. - Fix naming conventions and remove static access. - Add `.phpunit.result.cache` to `.gitignore`.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll acknowledge your comments with a 👀 emoji and then get to work. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! I will automatically address your feedback. For any comments you don't want me to act on, just include (aside). For security, I will only act on instructions from the user who triggered this task for this pull request. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+20
to
+113
| class AccessTest extends TestCase | ||
| { | ||
| public function testConstructor() | ||
| { | ||
| $pve = $this->getMockBuilder(PVE::class) | ||
| ->disableOriginalConstructor() | ||
| ->getMock(); | ||
|
|
||
| $api = $this->getMockBuilder(ApiPVE::class) | ||
| ->disableOriginalConstructor() | ||
| ->getMock(); | ||
|
|
||
| $pve->expects($this->once()) | ||
| ->method('getApi') | ||
| ->willReturn($api); | ||
|
|
||
| $api->expects($this->once()) | ||
| ->method('get') | ||
| ->with('access/') | ||
| ->willReturn(['data' => 'ok']); | ||
|
|
||
| $access = new Access($pve, ''); | ||
| } | ||
|
|
||
| public function testDomains() | ||
| { | ||
| $pve = $this->createMock(PVE::class); | ||
| $access = new Access($pve, ''); | ||
| $this->assertInstanceOf(Domains::class, $access->domains()); | ||
| } | ||
|
|
||
| public function testOpenId() | ||
| { | ||
| $pve = $this->createMock(PVE::class); | ||
| $access = new Access($pve, ''); | ||
| $this->assertInstanceOf(OpenId::class, $access->openId()); | ||
| } | ||
|
|
||
| public function testGroups() | ||
| { | ||
| $pve = $this->createMock(PVE::class); | ||
| $access = new Access($pve, ''); | ||
| $this->assertInstanceOf(Groups::class, $access->groups()); | ||
| } | ||
|
|
||
| public function testRoles() | ||
| { | ||
| $pve = $this->createMock(PVE::class); | ||
| $access = new Access($pve, ''); | ||
| $this->assertInstanceOf(Roles::class, $access->roles()); | ||
| } | ||
|
|
||
| public function testUsers() | ||
| { | ||
| $pve = $this->createMock(PVE::class); | ||
| $access = new Access($pve, ''); | ||
| $this->assertInstanceOf(Users::class, $access->users()); | ||
| } | ||
|
|
||
| public function testAcl() | ||
| { | ||
| $pve = $this->createMock(PVE::class); | ||
| $access = new Access($pve, ''); | ||
| $this->assertInstanceOf(Acl::class, $access->acl()); | ||
| } | ||
|
|
||
| public function testPassword() | ||
| { | ||
| $pve = $this->createMock(PVE::class); | ||
| $access = new Access($pve, ''); | ||
| $this->assertInstanceOf(Password::class, $access->password()); | ||
| } | ||
|
|
||
| public function testPermission() | ||
| { | ||
| $pve = $this->createMock(PVE::class); | ||
| $access = new Access($pve, ''); | ||
| $this->assertInstanceOf(Permission::class, $access->permission()); | ||
| } | ||
|
|
||
| public function testTfa() | ||
| { | ||
| $pve = $this->createMock(PVE::class); | ||
| $access = new Access($pve, ''); | ||
| $this->assertInstanceOf(Tfa::class, $access->tfa()); | ||
| } | ||
|
|
||
| public function testTicket() | ||
| { | ||
| $pve = $this->createMock(PVE::class); | ||
| $access = new Access($pve, ''); | ||
| $this->assertInstanceOf(Ticket::class, $access->ticket()); | ||
| } | ||
| } |
Check warning
Code scanning / PHPMD
Code Size Rules: TooManyPublicMethods Warning test
Comment on lines
+26
to
+162
| class ClusterTest extends TestCase | ||
| { | ||
| public function testGet() | ||
| { | ||
| $pve = $this->getMockBuilder(PVE::class) | ||
| ->disableOriginalConstructor() | ||
| ->getMock(); | ||
|
|
||
| $api = $this->getMockBuilder(ApiPVE::class) | ||
| ->disableOriginalConstructor() | ||
| ->getMock(); | ||
|
|
||
| $pve->expects($this->once()) | ||
| ->method('getApi') | ||
| ->willReturn($api); | ||
|
|
||
| $api->expects($this->once()) | ||
| ->method('get') | ||
| ->with('cluster/') | ||
| ->willReturn(['data' => 'ok']); | ||
|
|
||
| $cluster = new Cluster($pve, ''); | ||
| $this->assertEquals(['data' => 'ok'], $cluster->get()); | ||
| } | ||
|
|
||
| public function testAcme() | ||
| { | ||
| $pve = $this->createMock(PVE::class); | ||
| $cluster = new Cluster($pve, ''); | ||
| $this->assertInstanceOf(Acme::class, $cluster->acme()); | ||
| } | ||
|
|
||
| public function testBackup() | ||
| { | ||
| $pve = $this->createMock(PVE::class); | ||
| $cluster = new Cluster($pve, ''); | ||
| $this->assertInstanceOf(Backup::class, $cluster->backup()); | ||
| } | ||
|
|
||
| public function testBackupInfo() | ||
| { | ||
| $pve = $this->createMock(PVE::class); | ||
| $cluster = new Cluster($pve, ''); | ||
| $this->assertInstanceOf(BackupInfo::class, $cluster->backupInfo()); | ||
| } | ||
|
|
||
| public function testCeph() | ||
| { | ||
| $pve = $this->createMock(PVE::class); | ||
| $cluster = new Cluster($pve, ''); | ||
| $this->assertInstanceOf(Ceph::class, $cluster->ceph()); | ||
| } | ||
|
|
||
| public function testConfig() | ||
| { | ||
| $pve = $this->createMock(PVE::class); | ||
| $cluster = new Cluster($pve, ''); | ||
| $this->assertInstanceOf(Config::class, $cluster->config()); | ||
| } | ||
|
|
||
| public function testFirewall() | ||
| { | ||
| $pve = $this->createMock(PVE::class); | ||
| $cluster = new Cluster($pve, ''); | ||
| $this->assertInstanceOf(Firewall::class, $cluster->firewall()); | ||
| } | ||
|
|
||
| public function testHa() | ||
| { | ||
| $pve = $this->createMock(PVE::class); | ||
| $cluster = new Cluster($pve, ''); | ||
| $this->assertInstanceOf(Ha::class, $cluster->ha()); | ||
| } | ||
|
|
||
| public function testMetrics() | ||
| { | ||
| $pve = $this->createMock(PVE::class); | ||
| $cluster = new Cluster($pve, ''); | ||
| $this->assertInstanceOf(Metrics::class, $cluster->metrics()); | ||
| } | ||
|
|
||
| public function testReplication() | ||
| { | ||
| $pve = $this->createMock(PVE::class); | ||
| $cluster = new Cluster($pve, ''); | ||
| $this->assertInstanceOf(Replication::class, $cluster->replication()); | ||
| } | ||
|
|
||
| public function testSdn() | ||
| { | ||
| $pve = $this->createMock(PVE::class); | ||
| $cluster = new Cluster($pve, ''); | ||
| $this->assertInstanceOf(Sdn::class, $cluster->sdn()); | ||
| } | ||
|
|
||
| public function testLog() | ||
| { | ||
| $pve = $this->createMock(PVE::class); | ||
| $cluster = new Cluster($pve, ''); | ||
| $this->assertInstanceOf(Log::class, $cluster->log()); | ||
| } | ||
|
|
||
| public function testNextId() | ||
| { | ||
| $pve = $this->createMock(PVE::class); | ||
| $cluster = new Cluster($pve, ''); | ||
| $this->assertInstanceOf(NextId::class, $cluster->nextId()); | ||
| } | ||
|
|
||
| public function testOptions() | ||
| { | ||
| $pve = $this->createMock(PVE::class); | ||
| $cluster = new Cluster($pve, ''); | ||
| $this->assertInstanceOf(Options::class, $cluster->options()); | ||
| } | ||
|
|
||
| public function testResources() | ||
| { | ||
| $pve = $this->createMock(PVE::class); | ||
| $cluster = new Cluster($pve, ''); | ||
| $this->assertInstanceOf(Resources::class, $cluster->resources()); | ||
| } | ||
|
|
||
| public function testStatus() | ||
| { | ||
| $pve = $this->createMock(PVE::class); | ||
| $cluster = new Cluster($pve, ''); | ||
| $this->assertInstanceOf(Status::class, $cluster->status()); | ||
| } | ||
|
|
||
| public function testTasks() | ||
| { | ||
| $pve = $this->createMock(PVE::class); | ||
| $cluster = new Cluster($pve, ''); | ||
| $this->assertInstanceOf(Tasks::class, $cluster->tasks()); | ||
| } | ||
| } |
Check warning
Code scanning / PHPMD
Code Size Rules: TooManyPublicMethods Warning test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a testing framework (PHPUnit) and a static analysis tool (PHPMD) to the project. It also includes tests for the main API endpoints and refactors the core classes to improve code quality and testability.
PR created automatically by Jules for task 18296974841982686059