Skip to content

Fix Placemark rotation and tilt #869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Fix Placemark rotation and tilt #869

wants to merge 1 commit into from

Conversation

EMaksymenko
Copy link

Description of the Change

  1. Change order of unitSquareTransform matrix operations to fix image stretching on rotation and apply correct pivot point. Original code stretched texture instead of rotation and made rotation around texture center instead of specified offset point.
  2. Normalize unitSquareTransform matrix Z-range to prevent texture clipping on tilting. Original code had incorrect tilting approach.

Why Should This Be In Core?

Original code had incorrect placemark orientation processing logic and should be fixed.

Benefits

Now Placemarks are correctly rotated and tilted.

Potential Drawbacks

None

Applicable Issues

WorldWindEarth#63

@EMaksymenko
Fix Placemark rotation and tilt (#63):
d9d5c1f 
1) Change order of unitSquareTransform matrix operations to fix image stretching on rotation and apply correct pivot point.
2) Normalize unitSquareTransform matrix Z-range to prevent texture clipping on tilting.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@PJHogan PJHogan PJHogan approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EMaksymenko @PJHogan