Skip to content

Conversation

@dustinswales
Copy link
Member

@dustinswales dustinswales commented Sep 26, 2025

New test to demonstrate GNU failure when passing unallocated fields into the Group cap.
See error HERE

User interface changes?: No

Related to #690

Testing:
test removed:
unit tests:
system tests:
manual testing:

mkavulich and others added 8 commits February 4, 2025 15:06
…an modules in the correct place (#4)

Update CMakeLists.txt to:
- Bring in updates from NCAR ccpp-framework main as needed and update CMakeLists.txt to modern cmake version 3
- Support NEPTUNE cmake build while retaining compatibility with UFS/SCM
…an modules in the correct place (NCAR#653)

**Update src/CMakeLists.txt: use modern cmake features to install
Fortran modules in the correct place**

Update CMakeLists.txt to modern cmake version 3 and support NEPTUNE
cmake build while retaining compatibility with UFS/SCM

User interface changes?: No

Fixes: [Github issue #s] n/a

Testing: all CI tests pass, ran `capgen` and `prebuild` tests locally on
my laptop - all pass
  test removed:
  unit tests:
  system tests:
  manual testing:

Associated PRs:
- ccpp-physics: ufs-community/ccpp-physics#259
- FV3: NOAA-EMC/ufsatm#940
- ufs-weather-model:
ufs-community/ufs-weather-model#2659
Copy link
Collaborator

@gold2718 gold2718 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this PR be prioritized so that we can work towards a solution?

Copy link
Collaborator

@climbfuji climbfuji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Obviously, we can't merge this because it breaks the CI tests. Is the intention to keep this PR open until a fix is in place and the test passes?

@gold2718
Copy link
Collaborator

Obviously, we can't merge this because it breaks the CI tests. Is the intention to keep this PR open until a fix is in place and the test passes?

Fair. I suppose I can always cut a branch from this PR branch if I want to play with the problem.

@climbfuji
Copy link
Collaborator

Obviously, we can't merge this because it breaks the CI tests. Is the intention to keep this PR open until a fix is in place and the test passes?

Fair. I suppose I can always cut a branch from this PR branch if I want to play with the problem.

Correct, and we'll keep this branch up to date with develop so that you can always pull that in, too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants