Skip to content

Fix broken conditionals when using on ansible-core >= 2.19 because of some playbooks changes #420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 10, 2025
Merged

Fix broken conditionals when using on ansible-core >= 2.19 because of some playbooks changes #420

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
467579a
Refactor conditionals to ensure proper evaluation of package lists in…
gianmarco-mameli Nov 4, 2025
ea96055
Update changelogs/fragments/fix_broken_conditionals.yml
Donien Nov 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions changelogs/fragments/fix_broken_conditionals.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
bugfixes:
- "Fix broken conditionals when using on ansible-core >= 2.19 because of some playbooks changes"
4 changes: 2 additions & 2 deletions roles/monitoring_plugins/tasks/install_on_Debian.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
changed_when: apt_result.stdout is defined
when:
- needed_packages is defined
- needed_packages
- needed_packages | length > 0

- name: Apt - remove non-requested packages
become: yes
Expand All @@ -20,4 +20,4 @@
autoremove: "{{ icinga_monitoring_plugins_autoremove }}"
when:
- icinga_monitoring_plugins_remove
- unwanted_packages
- unwanted_packages | length > 0
6 changes: 3 additions & 3 deletions roles/monitoring_plugins/tasks/install_on_RedHat.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
when:
- ansible_distribution_major_version < "8"
- needed_packages is defined
- needed_packages
- needed_packages | length > 0

- name: Dnf - install requested packages
become: yes
Expand All @@ -26,7 +26,7 @@
when:
- ansible_distribution_major_version >= "8"
- needed_packages is defined
- needed_packages
- needed_packages | length > 0

- name: Yum - remove non-requested packages
become: yes
Expand All @@ -36,4 +36,4 @@
autoremove: "{{ icinga_monitoring_plugins_autoremove }}"
when:
- icinga_monitoring_plugins_remove
- unwanted_packages
- unwanted_packages | length > 0
4 changes: 2 additions & 2 deletions roles/monitoring_plugins/tasks/install_on_Suse.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
changed_when: zypper_result.stdout is defined
when:
- needed_packages is defined
- needed_packages
- needed_packages | length > 0

- name: Zypper - remove non-requested packages
become: yes
Expand All @@ -20,4 +20,4 @@
clean_deps: "{{ icinga_monitoring_plugins_autoremove }}"
when:
- icinga_monitoring_plugins_remove
- unwanted_packages
- unwanted_packages | length > 0