Jd/area balance fixes #1340
Merged
Jd/area balance fixes #1340
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…PowerSimulations.jl into jd/area_balance_fixes
m-bossart
requested changes
Aug 4, 2025
| @@ -553,52 +553,46 @@ function construct_service!( | |||
| return | |||
| end | |||
There was a problem hiding this comment.
Dispatch on PSY.TransmissionInterface and not T in line 531?
| @@ -676,7 +671,7 @@ function construct_service!( | |||
| add_parameters!(container, MaxInterfaceFlowLimitParameter, device, model) | |||
| end | |||
| end | |||
| interface = PSY.get_component(T, sys, get_service_name(model)) | |||
| interface = PSY.get_component(PSY.TransmissionInterface, sys, get_service_name(model)) | |||
| add_feedforward_arguments!(container, model, interface) | |||
| return | |||
| end | |||
There was a problem hiding this comment.
Dispatch on PSY.TransmissionInterface and not T in line 688?
| @@ -438,7 +438,7 @@ end | |||
| PSI.ModelBuildStatus.BUILT | |||
| moi_tests(model, 312, 0, 288, 288, 168, false) | |||
|
|
|||
| #= TODO: Fix this test | |||
| #= TODO: Fix this tes6 | |||
| @@ -586,3 +586,164 @@ end | |||
| ) | |||
| @test_throws ArgumentError build!(sim; console_level = Logging.AboveMaxLevel) | |||
| end | |||
|
|
|||
| @testset "2 Areas AreaBalance With Transmission Interface" begin | |||
There was a problem hiding this comment.
This test name seems misleading, because it only models the interchanges not the interfaces?
| @test size(interchange_constraints_ub) == (1, 24) | ||
| @test size(interchange_constraints_lb) == (1, 24) | ||
|
|
||
| interchange_constraints_ub["interface1_2_3", 1] |
Comment on lines
+687
to
+695
| interface = TransmissionInterface(; | ||
| name = "interface1_2_3", | ||
| available = true, | ||
| active_power_flow_limits = (min = 0.0, max = 1.0), | ||
| violation_penalty = 1000.0, | ||
| direction_mapping = Dict("interchange1_2" => 1, | ||
| "interchange1_3" => -1, | ||
| ), | ||
| ) |
There was a problem hiding this comment.
interchange1_2 and interchange1_3 are both defined as the flows out of area 1, so wouldn't the direction be -1 for both of them when defining the interface if we want to limit all the flows into 1?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests need QA/QC for the new Interface for Interchanges. It requires NREL-Sienna/PowerSystems.jl#1485