Skip to content

CI: Harden GHA Config #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
maffettone wants to merge 5 commits into
base: humble
Choose a base branch
from
Open

CI: Harden GHA Config #63

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8269552
CI: harden GHA configuration
tacaswell Jul 8, 2025
0e1f13c
CI: pin actions by SHA
tacaswell Jul 8, 2025
19f8c18
CI: Restrict default permissions
tacaswell Jul 9, 2025
665e59b
fix: entrypoint paths for lint
maffettone Jul 9, 2025
00f8b63
fix: fully qualified path
maffettone Jul 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/actions/lint/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@ description: 'Lint using devcontainer'
runs:
using: 'docker'
image: '../../../.devcontainer/Dockerfile'
entrypoint: ".github/actions/lint/run.sh"
entrypoint: "/github/workspace/.github/actions/lint/run.sh"
2 changes: 1 addition & 1 deletion .github/actions/test/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@ description: 'Test using devcontainer'
runs:
using: 'docker'
image: '../../../.devcontainer/Dockerfile'
entrypoint: ".github/actions/test/run.sh"
entrypoint: "/github/workspace/.github/actions/test/run.sh"
6 changes: 6 additions & 0 deletions .github/workflows/ros.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
name: ROS C++ Testing and Linting
permissions:
contents: read

on:
push:
Expand All @@ -14,6 +16,8 @@ jobs:
steps:
- name: Checkout code
uses: actions/checkout@v4
with:
persist-credentials: false
- name: Test
uses: ./.github/actions/test/

Expand All @@ -27,6 +31,8 @@ jobs:
steps:
- name: Checkout code
uses: actions/checkout@v4
with:
persist-credentials: false
- name: Run linter
uses: ./.github/actions/lint/
env:
Expand Down
6 changes: 5 additions & 1 deletion .github/workflows/ruff.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
name: Check Code Style - Ruff
permissions:
contents: read

on:
push:
Expand All @@ -12,8 +14,10 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
with:
persist-credentials: false
- uses: actions/setup-python@v5
- uses: astral-sh/ruff-action@v3
- uses: astral-sh/ruff-action@eaf0ecdd668ceea36159ff9d91882c9795d89b49 # v3
- name: Ruff Check
run: ruff check --fix
- name: Ruff Format
Expand Down
4 changes: 3 additions & 1 deletion .github/workflows/super-linter.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@
# For more information, see:
# https://github.com/github/super-linter
name: Lint Code Base (Super-Linter)
permissions:
contents: read

on:
push:
Expand All @@ -18,8 +20,8 @@ jobs:
- name: Checkout code
uses: actions/checkout@v4
with:
# Full git history is needed to get a proper list of changed files within `super-linter`
fetch-depth: 0
persist-credentials: false

- name: Lint Code Base
uses: github/super-linter@v7
Expand Down
Loading