Rope asr aed ngpt #13933
Merged
Rope asr aed ngpt #13933
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nune <ntadevosyan@nvidia.com>
Signed-off-by: Nune <ntadevosyan@nvidia.com>
Signed-off-by: Nune <ntadevosyan@nvidia.com>
pzelasko
reviewed
Jun 17, 2025
| return ans | ||
|
|
||
| def normalize_matrices(self): | ||
| with torch.no_grad(): |
Collaborator
There was a problem hiding this comment.
why remove torch.no_grad?
Collaborator
Author
There was a problem hiding this comment.
Missed it. Updated
pzelasko
reviewed
Jun 17, 2025
| from collections import OrderedDict | ||
| from dataclasses import dataclass | ||
|
|
||
| from rotary_embedding_torch import RotaryEmbedding |
pzelasko
reviewed
Jun 17, 2025
|
|
||
|
|
||
| def justnorm(x, fp32: bool = False, idim: int = -1): | ||
| def justnorm(x, fp32: bool = False, idim: int = -1,eps: float = 1e-10): |
Collaborator
There was a problem hiding this comment.
instead of 1e-10 which might be not representable in low precision types, use torch.finfo(x.dtype).eps https://docs.pytorch.org/docs/stable/type_info.html#torch.torch.finfo
Signed-off-by: Nune <ntadevosyan@nvidia.com>
Signed-off-by: nune-tadevosyan <152167970+nune-tadevosyan@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information