Skip to content

Conversation

@chtruong814
Copy link
Collaborator

What does this PR do ?

Cherry-picks these PRs that remove the NLP module:

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

dimapihtar and others added 4 commits January 5, 2026 18:04
* remove nlp.parts collection

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* remove nemo legacy import

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* remove nlp.parts collection

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* fix style

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* fix style

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* Apply isort and black reformatting

Signed-off-by: dimapihtar <dimapihtar@users.noreply.github.com>

* move nlp_overrides

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* fix styl

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* remove extra scripts

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* remove extra test

Signed-off-by: dimapihtar <dpihtar@gmail.com>

---------

Signed-off-by: dimapihtar <dpihtar@gmail.com>
Signed-off-by: dimapihtar <dimapihtar@users.noreply.github.com>
Co-authored-by: dimapihtar <dimapihtar@users.noreply.github.com>
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
* move tokenizer_utils

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* remove tokenizer_utils

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* Apply isort and black reformatting

Signed-off-by: dimapihtar <dimapihtar@users.noreply.github.com>

* fix style

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* Apply isort and black reformatting

Signed-off-by: dimapihtar <dimapihtar@users.noreply.github.com>

* fix style

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* remove extra import

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* move vocab file name

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* Apply isort and black reformatting

Signed-off-by: dimapihtar <dimapihtar@users.noreply.github.com>

* remove HF imports

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* remove hyena submodule

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* remove transformer submodule

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* Apply isort and black reformatting

Signed-off-by: dimapihtar <dimapihtar@users.noreply.github.com>

* fix style

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* Apply isort and black reformatting

Signed-off-by: dimapihtar <dimapihtar@users.noreply.github.com>

* remove .py files

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* Apply isort and black reformatting

Signed-off-by: dimapihtar <dimapihtar@users.noreply.github.com>

* remove .py files

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* remove .py files

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* remove .py files

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* fix style

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* remove nlp.modules.megatron

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* remove nlp collection

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* Apply isort and black reformatting

Signed-off-by: dimapihtar <dimapihtar@users.noreply.github.com>

* fix style

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* fix code style

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* fix code style

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* fix code style

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* fix import

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* Apply isort and black reformatting

Signed-off-by: dimapihtar <dimapihtar@users.noreply.github.com>

* fix code style

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* fix imports

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* fix import

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* fix imports

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* Apply isort and black reformatting

Signed-off-by: dimapihtar <dimapihtar@users.noreply.github.com>

* fix imports

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* remove unused function

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* fix import

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* Apply isort and black reformatting

Signed-off-by: dimapihtar <dimapihtar@users.noreply.github.com>

* fix imports

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* fix unit tests

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* fix imports

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* fix imports

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* fix import

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* fix import

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* fix code style

Signed-off-by: dimapihtar <dpihtar@gmail.com>

---------

Signed-off-by: dimapihtar <dpihtar@gmail.com>
Signed-off-by: dimapihtar <dimapihtar@users.noreply.github.com>
Co-authored-by: dimapihtar <dimapihtar@users.noreply.github.com>
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
* remove HeteronymClassificationModel

Signed-off-by: Jason <jasoli@nvidia.com>

* pylint

Signed-off-by: Jason <jasoli@nvidia.com>

---------

Signed-off-by: Jason <jasoli@nvidia.com>
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
@chtruong814
Copy link
Collaborator Author

CI passed as part of this consolidated PR: #15251

@chtruong814 chtruong814 merged commit 6b59df1 into r2.6.0 Jan 6, 2026
37 checks passed
@chtruong814 chtruong814 deleted the chtruong/cp-remove-nlp branch January 6, 2026 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants