-
Notifications
You must be signed in to change notification settings - Fork 3.3k
cp: Remove nlp module #15258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
cp: Remove nlp module #15258
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* remove nlp.parts collection Signed-off-by: dimapihtar <dpihtar@gmail.com> * remove nemo legacy import Signed-off-by: dimapihtar <dpihtar@gmail.com> * remove nlp.parts collection Signed-off-by: dimapihtar <dpihtar@gmail.com> * fix style Signed-off-by: dimapihtar <dpihtar@gmail.com> * fix style Signed-off-by: dimapihtar <dpihtar@gmail.com> * Apply isort and black reformatting Signed-off-by: dimapihtar <dimapihtar@users.noreply.github.com> * move nlp_overrides Signed-off-by: dimapihtar <dpihtar@gmail.com> * fix styl Signed-off-by: dimapihtar <dpihtar@gmail.com> * remove extra scripts Signed-off-by: dimapihtar <dpihtar@gmail.com> * remove extra test Signed-off-by: dimapihtar <dpihtar@gmail.com> --------- Signed-off-by: dimapihtar <dpihtar@gmail.com> Signed-off-by: dimapihtar <dimapihtar@users.noreply.github.com> Co-authored-by: dimapihtar <dimapihtar@users.noreply.github.com> Signed-off-by: Charlie Truong <chtruong@nvidia.com>
* move tokenizer_utils Signed-off-by: dimapihtar <dpihtar@gmail.com> * remove tokenizer_utils Signed-off-by: dimapihtar <dpihtar@gmail.com> * Apply isort and black reformatting Signed-off-by: dimapihtar <dimapihtar@users.noreply.github.com> * fix style Signed-off-by: dimapihtar <dpihtar@gmail.com> * Apply isort and black reformatting Signed-off-by: dimapihtar <dimapihtar@users.noreply.github.com> * fix style Signed-off-by: dimapihtar <dpihtar@gmail.com> * remove extra import Signed-off-by: dimapihtar <dpihtar@gmail.com> * move vocab file name Signed-off-by: dimapihtar <dpihtar@gmail.com> * Apply isort and black reformatting Signed-off-by: dimapihtar <dimapihtar@users.noreply.github.com> * remove HF imports Signed-off-by: dimapihtar <dpihtar@gmail.com> * remove hyena submodule Signed-off-by: dimapihtar <dpihtar@gmail.com> * remove transformer submodule Signed-off-by: dimapihtar <dpihtar@gmail.com> * Apply isort and black reformatting Signed-off-by: dimapihtar <dimapihtar@users.noreply.github.com> * fix style Signed-off-by: dimapihtar <dpihtar@gmail.com> * Apply isort and black reformatting Signed-off-by: dimapihtar <dimapihtar@users.noreply.github.com> * remove .py files Signed-off-by: dimapihtar <dpihtar@gmail.com> * Apply isort and black reformatting Signed-off-by: dimapihtar <dimapihtar@users.noreply.github.com> * remove .py files Signed-off-by: dimapihtar <dpihtar@gmail.com> * remove .py files Signed-off-by: dimapihtar <dpihtar@gmail.com> * remove .py files Signed-off-by: dimapihtar <dpihtar@gmail.com> * fix style Signed-off-by: dimapihtar <dpihtar@gmail.com> * remove nlp.modules.megatron Signed-off-by: dimapihtar <dpihtar@gmail.com> * remove nlp collection Signed-off-by: dimapihtar <dpihtar@gmail.com> * Apply isort and black reformatting Signed-off-by: dimapihtar <dimapihtar@users.noreply.github.com> * fix style Signed-off-by: dimapihtar <dpihtar@gmail.com> * fix code style Signed-off-by: dimapihtar <dpihtar@gmail.com> * fix code style Signed-off-by: dimapihtar <dpihtar@gmail.com> * fix code style Signed-off-by: dimapihtar <dpihtar@gmail.com> * fix import Signed-off-by: dimapihtar <dpihtar@gmail.com> * Apply isort and black reformatting Signed-off-by: dimapihtar <dimapihtar@users.noreply.github.com> * fix code style Signed-off-by: dimapihtar <dpihtar@gmail.com> * fix imports Signed-off-by: dimapihtar <dpihtar@gmail.com> * fix import Signed-off-by: dimapihtar <dpihtar@gmail.com> * fix imports Signed-off-by: dimapihtar <dpihtar@gmail.com> * Apply isort and black reformatting Signed-off-by: dimapihtar <dimapihtar@users.noreply.github.com> * fix imports Signed-off-by: dimapihtar <dpihtar@gmail.com> * remove unused function Signed-off-by: dimapihtar <dpihtar@gmail.com> * fix import Signed-off-by: dimapihtar <dpihtar@gmail.com> * Apply isort and black reformatting Signed-off-by: dimapihtar <dimapihtar@users.noreply.github.com> * fix imports Signed-off-by: dimapihtar <dpihtar@gmail.com> * fix unit tests Signed-off-by: dimapihtar <dpihtar@gmail.com> * fix imports Signed-off-by: dimapihtar <dpihtar@gmail.com> * fix imports Signed-off-by: dimapihtar <dpihtar@gmail.com> * fix import Signed-off-by: dimapihtar <dpihtar@gmail.com> * fix import Signed-off-by: dimapihtar <dpihtar@gmail.com> * fix code style Signed-off-by: dimapihtar <dpihtar@gmail.com> --------- Signed-off-by: dimapihtar <dpihtar@gmail.com> Signed-off-by: dimapihtar <dimapihtar@users.noreply.github.com> Co-authored-by: dimapihtar <dimapihtar@users.noreply.github.com> Signed-off-by: Charlie Truong <chtruong@nvidia.com>
* remove HeteronymClassificationModel Signed-off-by: Jason <jasoli@nvidia.com> * pylint Signed-off-by: Jason <jasoli@nvidia.com> --------- Signed-off-by: Jason <jasoli@nvidia.com> Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Collaborator
Author
ko3n1g
approved these changes
Jan 6, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Cherry-picks these PRs that remove the NLP module:
Collection: [Note which collection this PR will affect]
Changelog
Usage
# Add a code snippet demonstrating how to use thisGitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information