-
Notifications
You must be signed in to change notification settings - Fork 3.3k
Update CONTRIBUTING.md #15260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CONTRIBUTING.md #15260
Conversation
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
CONTRIBUTING.md
Outdated
| 1. For changes to NeMo's ASR collection: @titu1994, @redoctopus, @jbalam-nv, or @okuchaiev | ||
| 1. For changes to NeMo's NLP collection: @MaximumEntropy, @ericharper, @ekmb, @yzhang123, @VahidooX, @vladgets, or @okuchaiev | ||
| 1. For changes to NeMo's TTS collection: @blisc, or @okuchaiev | ||
| Tag @nithinraok or @blisc initially for a review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nithinraok who should be tagged here assuming the repo is just Speech?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this is good enough. May be we can be specific, something like:
Please tag @nithinraok for NeMo core and ASR related works, @blisc for TTS related.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated. Please take another look.
Co-authored-by: oliver könig <okoenig@nvidia.com> Signed-off-by: Charlie Truong <chtruong@nvidia.com>
|
currently all issues are getting assigned to Oleksii by default. Can we also update them. |
|
@nithinraok I created an issue to test if it was tagging someone by default, and it didn't seem to happen? Do you know of recent cases? |
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
nithinraok
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @chtruong814. We should be good then. |
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
What does this PR do ?
Update CONTRIBUTING.md
@nithinraok requested we update the Contributing guide.
pytestand run the entire test suite successfully. I updated the guide to indicate that it is best to run the unit test suite based on what changed and reference theL0_Unit_Testscripts for specific env vars needed.Collection: [Note which collection this PR will affect]
Changelog
Usage
# Add a code snippet demonstrating how to use thisGitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information