Skip to content

Fix mpi library linking issue #612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix mpi library linking issue #612

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ec3ad67
Update CMakeLists.txt
liangfu May 16, 2023
8e74e8e
Update CMakeLists.txt
liangfu May 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -418,7 +418,7 @@ add_library(transformer-shared SHARED

if (BUILD_MULTI_GPU)
target_link_libraries(transformer-shared PUBLIC
-lmpi
${MPI_mpi_LIBRARY}
${NCCL_LIBRARIES}
)
endif()
Expand Down
2 changes: 1 addition & 1 deletion src/fastertransformer/utils/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ add_library(mpi_utils STATIC mpi_utils.cc)
set_property(TARGET mpi_utils PROPERTY POSITION_INDEPENDENT_CODE ON)
set_property(TARGET mpi_utils PROPERTY CUDA_RESOLVE_DEVICE_SYMBOLS ON)
if (BUILD_MULTI_GPU)
target_link_libraries(mpi_utils PUBLIC -lmpi logger)
target_link_libraries(mpi_utils PUBLIC ${MPI_mpi_LIBRARY} logger)
endif()

add_library(nccl_utils STATIC nccl_utils.cc)
Expand Down