Skip to content

Conversation

@tarushi2k2
Copy link
Contributor

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Before your PR is "Ready for review"

Pre checks:

  • Have you signed your commits? Use git commit -s to sign.
  • Do all unittests finish successfully before sending PR?
    1. pytest or (if your machine does not have GPU) pytest --cpu from the root folder (given you marked your test cases accordingly @pytest.mark.run_only_on('CPU')).
    2. Sparrowhawk tests bash tools/text_processing_deployment/export_grammars.sh --MODE=test ...
  • If you are adding a new feature: Have you added test cases for both pytest and Sparrowhawk here.
  • Have you added __init__.py for every folder and subfolder, including data folder which has .TSV files?
  • Have you followed codeQL results and removed unused variables and imports (report is at the bottom of the PR in github review box) ?
  • Have you added the correct license header Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES. All rights reserved. to all newly added Python files?
  • If you copied nemo_text_processing/text_normalization/en/graph_utils.py your header's second line should be Copyright 2015 and onwards Google, Inc.. See an example here.
  • Remove import guards (try import: ... except: ...) if not already done.
  • If you added a new language or a new feature please update the NeMo documentation (lives in different repo).
  • Have you added your language support to tools/text_processing_deployment/pynini_export.py.

PR Type:

  • New Feature
  • Bugfix
  • Documentation
  • Test

If you haven't finished some of the above items you can still open "Draft" PR.

tarushi2k2 and others added 6 commits November 27, 2024 15:17
Signed-off-by: Tarushi V <tarushiv@nvidia.com>
Signed-off-by: Tarushi V <tarushiv@nvidia.com>
Signed-off-by: Tarushi V <tarushiv@nvidia.com>
Signed-off-by: Tarushi V <tarushiv@nvidia.com>
Signed-off-by: Tarushi V <tarushiv@nvidia.com>
@mgrafu mgrafu merged commit fee92c5 into NVIDIA:main Dec 2, 2024
5 checks passed
ngachchi pushed a commit to ngachchi/NeMo-text-processing that referenced this pull request Jun 23, 2025
* Addition of whitelist and word classes

Signed-off-by: Tarushi V <tarushiv@nvidia.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Updation of Jenkins date

Signed-off-by: Tarushi V <tarushiv@nvidia.com>

* Cleanup

Signed-off-by: Tarushi V <tarushiv@nvidia.com>

* Updation

Signed-off-by: Tarushi V <tarushiv@nvidia.com>

* Updation

Signed-off-by: Tarushi V <tarushiv@nvidia.com>

---------

Signed-off-by: Tarushi V <tarushiv@nvidia.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: Namrata Gachchi <ngachchi@nvidia.com>
FredHaa pushed a commit to FredHaa/NeMo-text-processing that referenced this pull request Aug 15, 2025
* Addition of whitelist and word classes

Signed-off-by: Tarushi V <tarushiv@nvidia.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Updation of Jenkins date

Signed-off-by: Tarushi V <tarushiv@nvidia.com>

* Cleanup

Signed-off-by: Tarushi V <tarushiv@nvidia.com>

* Updation

Signed-off-by: Tarushi V <tarushiv@nvidia.com>

* Updation

Signed-off-by: Tarushi V <tarushiv@nvidia.com>

---------

Signed-off-by: Tarushi V <tarushiv@nvidia.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants