Adds support for minor denomination currencies #250
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Namrata Gachchi <ngachchi@nvidia.com>
Signed-off-by: Namrata Gachchi <ngachchi@nvidia.com>
Signed-off-by: Namrata Gachchi <ngachchi@nvidia.com>
Signed-off-by: Simon Zuberek <szuberek@nvidia.com>
for more information, see https://pre-commit.ci
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
Signed-off-by: Namrata Gachchi <ngachchi@nvidia.com>
Signed-off-by: Namrata Gachchi <ngachchi@nvidia.com>
Signed-off-by: Simon Zuberek <szuberek@nvidia.com>
Signed-off-by: Namrata Gachchi <ngachchi@nvidia.com>
Signed-off-by: Namrata Gachchi <ngachchi@nvidia.com>
for more information, see https://pre-commit.ci
* ja tn Signed-off-by: Alex Cui <alexcui1994@gmail.com> * adding ja Signed-off-by: Alex Cui <alexcui1994@gmail.com> * removing Signed-off-by: Alex Cui <alexcui1994@gmail.com> * updated tests Signed-off-by: Alex Cui <alexcui1994@gmail.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * addressing comment Signed-off-by: Alex Cui <alexcui1994@gmail.com> * addressing ci Signed-off-by: Alex Cui <alexcui1994@gmail.com> * addressing ci Signed-off-by: Alex Cui <alexcui1994@gmail.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * addresing comment Signed-off-by: Alex Cui <alexcui1994@gmail.com> * removing Signed-off-by: Alex Cui <alexcui1994@gmail.com> * adresing comment Signed-off-by: Alex Cui <alexcui1994@gmail.com> * removing unused import Signed-off-by: Alex Cui <alexcui1994@gmail.com> * addressing comment Signed-off-by: Alex Cui <alexcui1994@gmail.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * addressing comment; Signed-off-by: Alex Cui <alexcui1994@gmail.com> * addressing comment Signed-off-by: Alex Cui <alexcui1994@gmail.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * date for ja Signed-off-by: Alex Cui <alexcui1994@gmail.com> * addresing comment Signed-off-by: Alex Cui <alexcui1994@gmail.com> * addressing comment Signed-off-by: Alex Cui <alexcui1994@gmail.com> * jenkins Signed-off-by: Alex Cui <alexcui1994@gmail.com> * addresing comment Signed-off-by: Alex Cui <alexcui1994@gmail.com> * addressing comment Signed-off-by: Alex Cui <alexcui1994@gmail.com> * typo Signed-off-by: Alex Cui <alexcui1994@gmail.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * adressing comment Signed-off-by: Alex Cui <alexcui1994@gmail.com> * addressing comment Signed-off-by: Alex Cui <alexcui1994@gmail.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * ci Signed-off-by: Alex Cui <alexcui1994@gmail.com> --------- Signed-off-by: Alex Cui <alexcui1994@gmail.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Signed-off-by: Namrata Gachchi <ngachchi@nvidia.com>
* Fixes issue 228 Signed-off-by: Simon Zuberek <szuberek@nvidia.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Fixes issue 228 Signed-off-by: Simon Zuberek <szuberek@nvidia.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Expands Whitelist and removes redundant [0-9]+-[A-Za-z] (and in reverse) pattern matching from ELECTRONIC Signed-off-by: Simon Zuberek <szuberek@nvidia.com> * Updates the cache Signed-off-by: Simon Zuberek <szuberek@nvidia.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Removes unused imports and variables Signed-off-by: Simon Zuberek <szuberek@nvidia.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Removes redundant abbreviation mappings Signed-off-by: Simon Zuberek <szuberek@nvidia.com> * Updates the cache Signed-off-by: Simon Zuberek <szuberek@nvidia.com> --------- Signed-off-by: Simon Zuberek <szuberek@nvidia.com> Co-authored-by: Simon Zuberek <szuberek@nvidia.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Signed-off-by: Namrata Gachchi <ngachchi@nvidia.com>
Signed-off-by: Namrata Gachchi <ngachchi@nvidia.com>
for more information, see https://pre-commit.ci Signed-off-by: Namrata Gachchi <ngachchi@nvidia.com>
Signed-off-by: Namrata Gachchi <ngachchi@nvidia.com>
Signed-off-by: Namrata Gachchi <ngachchi@nvidia.com>
for more information, see https://pre-commit.ci Signed-off-by: Namrata Gachchi <ngachchi@nvidia.com>
…g the file opened Signed-off-by: Namrata Gachchi <ngachchi@nvidia.com>
for more information, see https://pre-commit.ci
…e, Money and Measure (#223) * Hindi ITN Support for Cardinal, Decimal, Ordinal, Fraction, Date, Time Signed-off-by: Tarushi V <tarushiv@nvidia.com> * Cleanup Signed-off-by: Tarushi V <tarushiv@nvidia.com> * Cleanup Signed-off-by: Tarushi V <tarushiv@nvidia.com> * Committing all changes made Signed-off-by: Tarushi V <tarushiv@nvidia.com> * Updated date.py and added more test cases to cardinal for improved accuracy Signed-off-by: Tarushi V <tarushiv@nvidia.com> * Updated date.py Signed-off-by: Tarushi V <tarushiv@nvidia.com> * Added hi to Jenkins and cleanup Signed-off-by: Tarushi V <tarushiv@nvidia.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Changes and cleanup based on feedback Signed-off-by: Tarushi V <tarushiv@nvidia.com> * Changes and cleanup based on feedback Signed-off-by: Tarushi V <tarushiv@nvidia.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Resolved conflicts Signed-off-by: Tarushi V <tarushiv@nvidia.com> * Committing code for measure.py Signed-off-by: Tarushi V <tarushiv@nvidia.com> * Cleanup Signed-off-by: Tarushi V <tarushiv@nvidia.com> * Cleanup Signed-off-by: Tarushi V <tarushiv@nvidia.com> * changes to run_evaluate.py Signed-off-by: Tarushi V <tarushiv@nvidia.com> * Hindi ITN for money.py Signed-off-by: Tarushi V <tarushiv@nvidia.com> * Changes and cleanup Signed-off-by: Tarushi V <tarushiv@nvidia.com> * Cleanup Signed-off-by: Tarushi V <tarushiv@nvidia.com> * Cleanup Signed-off-by: Tarushi V <tarushiv@nvidia.com> * Cleanup date verbalizer Signed-off-by: Tarushi V <tarushiv@nvidia.com> * Cleanup Signed-off-by: Tarushi V <tarushiv@nvidia.com> * Cleanup Signed-off-by: Tarushi V <tarushiv@nvidia.com> * Cleanup Signed-off-by: Tarushi V <tarushiv@nvidia.com> * Cleanup Signed-off-by: Tarushi V <tarushiv@nvidia.com> * Cleanup Signed-off-by: Tarushi V <tarushiv@nvidia.com> * Cleanup Signed-off-by: Tarushi V <tarushiv@nvidia.com> * Cleanup Signed-off-by: Tarushi V <tarushiv@nvidia.com> * pushing .gitignore file from main branch Signed-off-by: Tarushi V <tarushiv@nvidia.com> --------- Signed-off-by: Tarushi V <tarushiv@nvidia.com> Signed-off-by: tarushi2k2 <tarushiv@nvidia.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Signed-off-by: Namrata Gachchi <ngachchi@nvidia.com>
Signed-off-by: Namrata Gachchi <ngachchi@nvidia.com>
for more information, see https://pre-commit.ci Signed-off-by: Namrata Gachchi <ngachchi@nvidia.com>
Signed-off-by: Namrata Gachchi <ngachchi@nvidia.com>
…d word file Signed-off-by: Namrata Gachchi <ngachchi@nvidia.com>
Signed-off-by: Namrata Gachchi <ngachchi@nvidia.com>
for more information, see https://pre-commit.ci Signed-off-by: Namrata Gachchi <ngachchi@nvidia.com>
Signed-off-by: Simon Zuberek <szuberek@nvidia.com> Signed-off-by: Namrata Gachchi <ngachchi@nvidia.com>
Signed-off-by: Simon Zuberek <szuberek@nvidia.com> Signed-off-by: Namrata Gachchi <ngachchi@nvidia.com>
Signed-off-by: Namrata Gachchi <ngachchi@nvidia.com>
for more information, see https://pre-commit.ci Signed-off-by: Namrata Gachchi <ngachchi@nvidia.com>
* Fix space issue with ZH ITN Signed-off-by: Anand Joseph <anajoseph@nvidia.com> * Update Jenkinsfile Update FST paths Signed-off-by: anand-nv <105917641+anand-nv@users.noreply.github.com> --------- Signed-off-by: Anand Joseph <anajoseph@nvidia.com> Signed-off-by: anand-nv <105917641+anand-nv@users.noreply.github.com> Signed-off-by: Simon Zuberek <simon@zuberek.net> Co-authored-by: Anand Joseph <anajoseph@nvidia.com> Co-authored-by: anand-nv <105917641+anand-nv@users.noreply.github.com> Signed-off-by: Namrata Gachchi <ngachchi@nvidia.com>
* contributing update Signed-off-by: tbartley94 <tbartley@nvidia.com> * adding edits Signed-off-by: tbartley94 <tbartley@nvidia.com> * spelling Signed-off-by: tbartley94 <tbartley@nvidia.com> --------- Signed-off-by: tbartley94 <tbartley@nvidia.com> Signed-off-by: Namrata Gachchi <ngachchi@nvidia.com>
Signed-off-by: Namrata Gachchi <ngachchi@nvidia.com>
Signed-off-by: Namrata Gachchi <ngachchi@nvidia.com>
* Addition of whitelist and word classes Signed-off-by: Tarushi V <tarushiv@nvidia.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Updation of Jenkins date Signed-off-by: Tarushi V <tarushiv@nvidia.com> * Cleanup Signed-off-by: Tarushi V <tarushiv@nvidia.com> * Updation Signed-off-by: Tarushi V <tarushiv@nvidia.com> * Updation Signed-off-by: Tarushi V <tarushiv@nvidia.com> --------- Signed-off-by: Tarushi V <tarushiv@nvidia.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Signed-off-by: Namrata Gachchi <ngachchi@nvidia.com>
* Addition of whitelist and word classes Signed-off-by: Tarushi V <tarushiv@nvidia.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Updation of Jenkins date Signed-off-by: Tarushi V <tarushiv@nvidia.com> * Cleanup Signed-off-by: Tarushi V <tarushiv@nvidia.com> * Updation Signed-off-by: Tarushi V <tarushiv@nvidia.com> * Updation Signed-off-by: Tarushi V <tarushiv@nvidia.com> --------- Signed-off-by: Tarushi V <tarushiv@nvidia.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Signed-off-by: Namrata Gachchi <ngachchi@nvidia.com>
* Addition of whitelist and word classes Signed-off-by: Tarushi V <tarushiv@nvidia.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Updation of Jenkins date Signed-off-by: Tarushi V <tarushiv@nvidia.com> * Cleanup Signed-off-by: Tarushi V <tarushiv@nvidia.com> * Updation Signed-off-by: Tarushi V <tarushiv@nvidia.com> * Updation Signed-off-by: Tarushi V <tarushiv@nvidia.com> --------- Signed-off-by: Tarushi V <tarushiv@nvidia.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Signed-off-by: Namrata Gachchi <ngachchi@nvidia.com>
for more information, see https://pre-commit.ci Signed-off-by: Namrata Gachchi <ngachchi@nvidia.com>
for more information, see https://pre-commit.ci
Signed-off-by: Namrata Gachchi <ngachchi@nvidia.com>
for more information, see https://pre-commit.ci
Signed-off-by: Namrata Gachchi <ngachchi@nvidia.com>
for more information, see https://pre-commit.ci
|
This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days. |
Signed-off-by: Namrata Gachchi <ngachchi@nvidia.com>
for more information, see https://pre-commit.ci
Signed-off-by: Namrata Gachchi <ngachchi@nvidia.com>
Signed-off-by: Namrata Gachchi <ngachchi@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
17 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
This PR adds support for minor denomination currencies (e.g. cents for USD). The major - minor currency denomination pairs are stored in a dictionary under
data, and may be expanded according to the need and use case. The list of currency symbol - currency name mappings stored in the same directory can likewise be expanded.Before your PR is "Ready for review"
Pre checks:
git commit -sto sign.pytestor (if your machine does not have GPU)pytest --cpufrom the root folder (given you marked your test cases accordingly@pytest.mark.run_only_on('CPU')).bash tools/text_processing_deployment/export_grammars.sh --MODE=test ...pytestand Sparrowhawk here.__init__.pyfor every folder and subfolder, includingdatafolder which has .TSV files?Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES. All rights reserved.to all newly added Python files?Copyright 2015 and onwards Google, Inc.. See an example here.try import: ... except: ...) if not already done.PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.