contributing update #251
Merged
contributing update #251
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tbartley94 <tbartley@nvidia.com>
mgrafu
requested changes
Dec 10, 2024
Signed-off-by: tbartley94 <tbartley@nvidia.com>
mgrafu
reviewed
Dec 11, 2024
CONTRIBUTING.md
Outdated
|
|
||
| Naively, one may be tempted to simply include the property string `gender: "masc"` and check for this string during the verbalization phase. **This is not advised.** While the NeMo-Text-Processing library itself will permit any custom string in the tagger, Sparrowhawk limits permissible strings, and will fail with custom property strings. Given the performance loss in not providing Sparrowhawk support, we cannot integrate new graphs that cause Sparrowhawk failure. As such, tagged properties should be limited to Sparrowhawk supported strings. | ||
|
|
||
| For all classes, Sparrowhawk support the `morphosyntactic_features` property, and it is recommended to default to this property for tagging additional features. For example: |
mgrafu
approved these changes
Dec 11, 2024
ngachchi
pushed a commit
to ngachchi/NeMo-text-processing
that referenced
this pull request
Jun 23, 2025
* contributing update Signed-off-by: tbartley94 <tbartley@nvidia.com> * adding edits Signed-off-by: tbartley94 <tbartley@nvidia.com> * spelling Signed-off-by: tbartley94 <tbartley@nvidia.com> --------- Signed-off-by: tbartley94 <tbartley@nvidia.com> Signed-off-by: Namrata Gachchi <ngachchi@nvidia.com>
FredHaa
pushed a commit
to FredHaa/NeMo-text-processing
that referenced
this pull request
Aug 15, 2025
* contributing update Signed-off-by: tbartley94 <tbartley@nvidia.com> * adding edits Signed-off-by: tbartley94 <tbartley@nvidia.com> * spelling Signed-off-by: tbartley94 <tbartley@nvidia.com> --------- Signed-off-by: tbartley94 <tbartley@nvidia.com>
Rajanv307
pushed a commit
to RajanPutty/NeMo-text-processing
that referenced
this pull request
Jan 6, 2026
* contributing update Signed-off-by: tbartley94 <tbartley@nvidia.com> * adding edits Signed-off-by: tbartley94 <tbartley@nvidia.com> * spelling Signed-off-by: tbartley94 <tbartley@nvidia.com> --------- Signed-off-by: tbartley94 <tbartley@nvidia.com> Signed-off-by: RajanPutty <rputty@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
Before your PR is "Ready for review"
Pre checks:
git commit -sto sign.pytestor (if your machine does not have GPU)pytest --cpufrom the root folder (given you marked your test cases accordingly@pytest.mark.run_only_on('CPU')).bash tools/text_processing_deployment/export_grammars.sh --MODE=test ...pytestand Sparrowhawk here.__init__.pyfor every folder and subfolder, includingdatafolder which has .TSV files?Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES. All rights reserved.to all newly added Python files?Copyright 2015 and onwards Google, Inc.. See an example here.try import: ... except: ...) if not already done.PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.