[None][fix] Improve type annotations on ResourceManager.get_resource_manager

[ixlmar]

Description

Type annotation improvement.

Test Coverage

No new functionality.

PR Checklist

Please review the following before submitting your PR:

• PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

• PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

• Test cases are provided for new code paths (see test instructions)

• Any new dependencies have been scanned for license and vulnerabilities

• CODEOWNERS updated if ownership changes

• Documentation updated as needed

• Update tava architecture diagram if there is a significant design change in PR.

• The reviewers assigned automatically/manually are appropriate for the PR.

• Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

Summary by CodeRabbit

• Refactor
  • Resource manager API updated with stricter typing: method now accepts enum parameter replacing string input, and return type changed to Optional to accommodate cases where the resource may not be found.

[ixlmar]

/bot run

[coderabbitai]

📝 Walkthrough

Walkthrough

Modified the get_resource_manager method in the ResourceManager class to accept a ResourceManagerType enum parameter instead of a string, and return Optional[BaseResourceManager] instead of BaseResourceManager. The implementation uses name.value for enum lookups.

Changes

Cohort / File(s)	Summary
Resource Manager Type Safety tensorrt_llm/_torch/pyexecutor/resource_manager.py	Method signature updated: get_resource_manager now accepts ResourceManagerType enum instead of str and returns Optional[BaseResourceManager] instead of BaseResourceManager. Implementation uses name.value for enum-based lookup.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

• Verify that the ResourceManagerType enum includes all previously supported string values
• Check for any callers of this public method that require updates due to the breaking API change
• Confirm that the Optional return type is necessary and properly handled by callers
• Validate that name.value correctly accesses the internal resource manager mapping

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description check	✅ Passed	The description provides essential information about the change being a type annotation improvement with no new functionality, though it lacks specific details about what types were changed and why.
Title check	✅ Passed	The title accurately reflects the main change: improving type annotations on ResourceManager.get_resource_manager method, which is the primary modification in the changeset.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[tensorrt-cicd]

PR_Github #23862 [ run ] triggered by Bot. Commit: 702f0c5

[tensorrt-cicd]

PR_Github #23862 [ run ] completed with state FAILURE. Commit: 702f0c5
/LLM/main/L0_MergeRequest_PR pipeline #17963 completed with status: 'FAILURE'

[ixlmar]

/bot run --disable-fail-fast

[tensorrt-cicd]

PR_Github #23864 [ run ] triggered by Bot. Commit: 702f0c5

[tensorrt-cicd]

PR_Github #23864 [ run ] completed with state SUCCESS. Commit: 702f0c5
/LLM/main/L0_MergeRequest_PR pipeline #17965 completed with status: 'FAILURE'

[eopXD]

Might as well DCE the register_resource_manager function.

[ixlmar]

/bot run

[ixlmar]

Might as well DCE the register_resource_manager function.

Done

[tensorrt-cicd]

PR_Github #24007 [ run ] triggered by Bot. Commit: 2358d7f

[tensorrt-cicd]

PR_Github #24007 [ run ] completed with state SUCCESS. Commit: 2358d7f
/LLM/main/L0_MergeRequest_PR pipeline #18084 completed with status: 'SUCCESS'
Pipeline passed with automatic retried tests. Check the rerun report for details.