Skip to content

Conversation

@nvchenghaoz
Copy link
Collaborator

@nvchenghaoz nvchenghaoz commented Nov 7, 2025

The test is fixed by #8979

Summary by CodeRabbit

  • Tests
    • Re-enabled previously skipped test cases, expanding test coverage and validation.

Signed-off-by: Chenghao Zhang <211069071+nvchenghaoz@users.noreply.github.com>
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 7, 2025

📝 Walkthrough

Walkthrough

Two test skip entries were removed from the test waives list file, specifically skipping directives for TestLlama3_1_8B::test_auto_dtype[False-2] and TestLlama3_1_8B::test_auto_dtype[False-4].

Changes

Cohort / File(s) Summary
Test skip list maintenance
tests/integration/test_lists/waives.txt
Removed 2 SKIP directives for TestLlama3_1_8B::test_auto_dtype test variants

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

  • Verify that the removed skip entries correspond to tests that now pass or are no longer needed
  • Confirm the specific test parameters [False-2] and [False-4] are correctly identified

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Description check ❓ Inconclusive The PR description is minimal but not entirely complete. While it references the related PR (#8979) that fixed the test, it lacks a clear explanation of what was changed and why the tests are being unwaived. Expand the description to explain: 1) which tests were unwaived and why, 2) how PR #8979 fixed the underlying issue, and 3) confirm test coverage validates the fix.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The PR title clearly follows the required template and accurately describes the main change: unwaiving previously skipped tests in the waives.txt file.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 748c56a and ae0ba30.

📒 Files selected for processing (1)
  • tests/integration/test_lists/waives.txt (0 hunks)
💤 Files with no reviewable changes (1)
  • tests/integration/test_lists/waives.txt
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Pre-commit Check

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-project-automation github-project-automation bot moved this from Backlog to In review in AutoDeploy Board Nov 10, 2025
@nvchenghaoz nvchenghaoz enabled auto-merge (squash) November 10, 2025 18:30
@nvchenghaoz
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #24042 [ run ] triggered by Bot. Commit: ae0ba30

@tensorrt-cicd
Copy link
Collaborator

PR_Github #24042 [ run ] completed with state SUCCESS. Commit: ae0ba30
/LLM/main/L0_MergeRequest_PR pipeline #18116 completed with status: 'FAILURE'

@nvchenghaoz
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #24058 [ run ] triggered by Bot. Commit: 909876c

@tensorrt-cicd
Copy link
Collaborator

PR_Github #24058 [ run ] completed with state SUCCESS. Commit: 909876c
/LLM/main/L0_MergeRequest_PR pipeline #18130 completed with status: 'FAILURE'

@nvchenghaoz
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #24106 [ run ] triggered by Bot. Commit: 909876c

@tensorrt-cicd
Copy link
Collaborator

PR_Github #24106 [ run ] completed with state SUCCESS. Commit: 909876c
/LLM/main/L0_MergeRequest_PR pipeline #18172 completed with status: 'FAILURE'

@nvchenghaoz
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #24328 [ run ] triggered by Bot. Commit: 909876c

@tensorrt-cicd
Copy link
Collaborator

PR_Github #24328 [ run ] completed with state SUCCESS. Commit: 909876c
/LLM/main/L0_MergeRequest_PR pipeline #18357 completed with status: 'SUCCESS'

@nvchenghaoz nvchenghaoz merged commit 5f26c31 into NVIDIA:main Nov 12, 2025
5 checks passed
@github-project-automation github-project-automation bot moved this from In review to Done in AutoDeploy Board Nov 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants