Skip to content

Conversation

updates:
- [github.com/astral-sh/ruff-pre-commit: 9c89adb347f6b973f4905a4be0051eb2ecf85dea → 5ba58aca0bd5bc7c0e1c0fc45af2e88d6a2bde83](astral-sh/ruff-pre-commit@9c89adb...5ba58ac)
- [github.com/pre-commit/mirrors-mypy: 9f70dc58c23dfcca1b97af99eaeee3140a807c7e → a66e98df7b4aeeb3724184b332785976d062b92e](pre-commit/mirrors-mypy@9f70dc5...a66e98d)
- [github.com/rhysd/actionlint: 03d0035246f3e81f36aed592ffb4bebf33a03106 → 0933c147c9d6587653d45fdcb4c497c57a65f9af](rhysd/actionlint@03d0035...0933c14)
- [github.com/MarcoGorelli/cython-lint: d9ff7ce99ef4f2ae8fba93079ca9d76c4651d4ac → 8e4297a1b56d0c5be6f79be4e28d08e71d6c05b9](MarcoGorelli/cython-lint@d9ff7ce...8e4297a)
@copy-pr-bot
Copy link
Contributor

copy-pr-bot bot commented Jan 5, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@leofang
Copy link
Member

leofang commented Jan 6, 2026

It seems actionlint tightened up the syntax check: rhysd/actionlint#596

Lint GitHub Actions workflow files.......................................Failed
- hook id: actionlint
- exit code: 1

.github/workflows/test-wheel-windows.yml:208:15: could not parse action metadata in "/code/.github/actions/fetch_ctk": line 10: unexpected key "type" for definition of input "cuda-path" [action]
    |
208 |         uses: ./.github/actions/fetch_ctk
    |               ^~~~~~~~~~~~~~~~~~~~~~~~~~~
.github/workflows/build-docs.yml:248:15: could not parse action metadata in "/code/.github/actions/doc_preview": line 11: unexpected key "type" for definition of input "pr-number" [action]
    |
248 |         uses: ./.github/actions/doc_preview
    |               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
.github/workflows/build-wheel.yml:144:15: could not parse action metadata in "/code/.github/actions/fetch_ctk": line 10: unexpected key "type" for definition of input "cuda-path" [action]
    |
144 |         uses: ./.github/actions/fetch_ctk
    |               ^~~~~~~~~~~~~~~~~~~~~~~~~~~
.github/workflows/test-wheel-linux.yml:103:15: could not parse action metadata in "/code/.github/actions/install_unix_deps": line 10: unexpected key "type" for definition of input "dependent_exes" [action]
    |
103 |         uses: ./.github/actions/install_unix_deps
    |               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
.github/workflows/test-wheel-linux.yml:232:15: could not parse action metadata in "/code/.github/actions/fetch_ctk": line 10: unexpected key "type" for definition of input "cuda-path" [action]
    |
232 |         uses: ./.github/actions/fetch_ctk
    |               ^~~~~~~~~~~~~~~~~~~~~~~~~~~

@mdboom mdboom requested a review from kkraus14 January 6, 2026 14:51
@mdboom mdboom self-assigned this Jan 6, 2026
@mdboom
Copy link
Contributor

mdboom commented Jan 6, 2026

Self-assigning -- I'm going to look into making the necessary changes so the new lints pass.

@mdboom mdboom force-pushed the pre-commit-ci-update-config branch from 23ff8c1 to 1b9de90 Compare January 6, 2026 15:15
@mdboom
Copy link
Contributor

mdboom commented Jan 6, 2026

Fixed the following issues:

cuda-python/cuda_core/cuda/core/_memory/_memory_pool.pyx:310:33: 'loc' defined but unused (try prefixing with underscore?)
cuda-python/cuda_core/cuda/core/_memory/_managed_memory_resource.pyx:7:28: 'cydriver' imported but unused
cuda-python/cuda_core/cuda/core/_device.pyx:12:20: 'Optional' imported but unused

The first two appear to be false positives. Since the new version is producing false positives, IMHO, it's best not to update to it now. I did fix the last one though.

EDIT: Filed issues MarcoGorelli/cython-lint#165 and MarcoGorelli/cython-lint#166

@mdboom
Copy link
Contributor

mdboom commented Jan 6, 2026

/ok to test

@copy-pr-bot
Copy link
Contributor

copy-pr-bot bot commented Jan 6, 2026

/ok to test

@mdboom, there was an error processing your request: E1

See the following link for more information: https://docs.gha-runners.nvidia.com/cpr/e/1/

@mdboom
Copy link
Contributor

mdboom commented Jan 6, 2026

/ok to test 1b9de90

@github-actions

This comment has been minimized.

@cpcloud cpcloud merged commit 1dc914a into main Jan 6, 2026
80 checks passed
@cpcloud cpcloud deleted the pre-commit-ci-update-config branch January 6, 2026 16:44
@github-actions
Copy link

github-actions bot commented Jan 6, 2026

Doc Preview CI
Preview removed because the pull request was closed or merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants