cuda.core.system: Add system-level APIs #1440
Merged
+19
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Contributor
Author
|
/ok to test |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a new system-level API get_driver_branch() that retrieves the driver branch of the NVIDIA driver installed on the system by wrapping the NVML function nvmlSystemGetDriverBranch.
- Adds
get_driver_branch()function to_system.pyx - Adds test coverage for the new function
- Updates
__all__exports to include the new function
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| cuda_core/cuda/core/system/_system.pyx | Implements get_driver_branch() function and adds it to __all__ exports |
| cuda_core/tests/system/test_system_system.py | Adds test case for get_driver_branch() function |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
Author
|
/ok to test |
mdboom
added
enhancement
This comment has been minimized.
This comment has been minimized.
kkraus14
approved these changes
Jan 9, 2026
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that the skeleton of cuda.core.system is merged, I'm starting the process of methodically adding APIs. This adds the one remaining "system-level" API,
nvmlSystemGetDriverBranch.