-
Notifications
You must be signed in to change notification settings - Fork 417
Update Transolver + Add Transolver external_aero example #1022
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…he 'fix' version of the example easier to run, scalable, usable at full resolution, and faster
…meshes. Enhance documentation.
…lelism, this is a disk to gpu pipeline that natively optimizes bandwidth when domain parallel.
was used when projecting back onto output states.
/blossom-ci |
Some updates on this PR:
The goal here was to have a transformer-engine leveraging model, so focus was on training stability, model compatibility, and inference. |
@@ -0,0 +1,210 @@ | |||
# Transolver for External Aerodynamics on Irregular Meshes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and comprehensive overall. I am not calling out minor knit picks. We should have a section on customization - if a user needs to adapt this to a new problem, say CFD data from internal flow problem, what is the guidance in terms of where the user needs to look to customize - assume its VTK data, so can reuse the datapipe but what other elements would need modification.
introduces modifications for improved numerical stability and compatibility with NVIDIA | ||
TransformerEngine. | ||
|
||
The training workflow for Transolver leverages the same input datasets as DoMINO. For |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same input datasets as other models perhaps. We are specifically mentioning things in the context of DoMINO - can be avoided.
This has been divided into two PRS and merged separately. Closing. |
PhysicsNeMo Pull Request
This PR updates the transolver model and introduces an external aero example that uses it. Summary of changes to the model code:
Additionally, the darcy_transolver example was updated to accomodate these changes, and still converges like the paper result.
A summary of the external aero example:
There is not yet a good interface for inference with a trained model. For the surface data, considering the simplicity of the preprocessing and reuse of domino inputs, it should be straightforward.
Checklist
Dependencies