-
Notifications
You must be signed in to change notification settings - Fork 20
Contributor Documentation Updates #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Contributor Documentation Updates #8
Conversation
Remove non-maintained links Add useful getting started documentation Clarify debugging guide
|
All contributors have signed the CLA ✍️ ✅ |
WalkthroughDocumentation updates: CONTRIBUTING.md now references the Omniverse Kit SDK, adds an inline extension-development video, clarifies repository namespace labels for Lightspeed and Flux, adds an automated PR/CLA prompt note, and reorganizes Additional Documentation; DEBUGGING_GUIDE.md updates VS Code debug extension enablement to use Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Path: .coderabbit.yml Review profile: CHILL Plan: Pro Disabled knowledge base sources:
📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Warning Review ran into problems🔥 ProblemsErrors were encountered while retrieving linked issues. Errors (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
docs_dev/DEBUGGING_GUIDE.md (1)
36-37: Clarify backtick placement in multi-line sentence.The backtick at the end of line 36 creates awkward formatting. Consider restructuring to improve readability.
-For example for VSCode or Cursor, we already have setup `.vscode/launch.json`, otherwise you can create your own with a` -`Python: Remote Attach` config like this and run it to attach to the server: +For example for VSCode or Cursor, we already have setup `.vscode/launch.json`; otherwise you can create your own with a `Python: Remote Attach` config like this and run it to attach to the server:
📜 Review details
Configuration used: Path: .coderabbit.yml
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Jira integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (2)
docs_dev/CONTRIBUTING.md(2 hunks)docs_dev/DEBUGGING_GUIDE.md(1 hunks)
🔇 Additional comments (6)
docs_dev/DEBUGGING_GUIDE.md (1)
23-30: Verify debugging instructions and updated workflow.The changes correctly clarify that users should run
lightspeed.app.trex_dev.batbefore enabling the VS Code debug extension via the GUI, aligning with the PR objective. The workflow appears sound and provides clearer setup guidance than before.docs_dev/CONTRIBUTING.md (5)
25-26: Repository structure naming clarification is helpful.Adding naming convention context (lightspeed.trex., omni.flux.) provides clear identifiers for developers navigating the codebase and improves the developer experience.
28-29: Verify relative path reference to extensions directory.The relative path
../source/extensionsassumes the docs are being read fromdocs_dev/context. Confirm this path is correct for the intended documentation viewer/platform.
73-74: Documentation reorganization improves navigation.Separating "Using Pycharm IDE" from debugging guidance and adding a dedicated "Debugging Guide" entry provides clearer navigation and aligns with the PR objective to adjust click-through paths. The new structure allows readers to find debugging resources without traversing PyCharm setup.
15-19: Clarify USDBook resource retention.The PR objectives mention updating and removing deprecated resources. USDBook by Remedy Entertainment (line 19) is currently included, but its retention status is unclear. Confirm whether this resource should remain or be removed.
8-13: Strong onboarding improvements with SDK reference and video embed.The rewritten Getting Started section effectively introduces the Omniverse Kit SDK foundation and adds a visual learning resource via embedded YouTube video for "Build Your First Omniverse Extension With OpenUSD." The video link is active and directly relevant to the Omniverse extension development context. This addresses the PR objective to ease onboarding for new developers.
nxkb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this. Looks good to me, just need those 2 minor notes addressed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
docs_dev/DEBUGGING_GUIDE.md (1)
36-36: Minor grammatical refinement.Line 36 uses slightly awkward phrasing: "we already have setup" should be "we have already set up" or "we've already set up" for consistency with standard English.
Apply this diff for improved grammar:
-For example for VSCode or Cursor, we already have setup `.vscode/launch.json`, otherwise you can create your own with a +For example for VSCode or Cursor, we have already set up `.vscode/launch.json`, otherwise you can create your own with a
📜 Review details
Configuration used: Path: .coderabbit.yml
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Jira integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
docs_dev/DEBUGGING_GUIDE.md(1 hunks)
🔇 Additional comments (1)
docs_dev/DEBUGGING_GUIDE.md (1)
29-30: Documentation clarifies VS Code extension enablement workflow.The updated content properly explains the new flow for enabling
omni.kit.debug.vscodevialightspeed.app.trex_dev.bat. However, verify that the.vscode/launch.jsonfile referenced on line 36 exists and contains valid configuration before merging.
|
Requested changes should all be resolved at this point |
|
I have read the CLA Document and I hereby sign the CLA |
Update contributor documentation for easier onboarding of new open-source devs:
lightspeed.app.trex_dev.batSummary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.