Skip to content

Conversation

@MistakeNot4892
Copy link
Contributor

@MistakeNot4892 MistakeNot4892 commented Nov 26, 2025

Description of changes

  • Adds a bunch of sign icons from Polaris.
  • Unifies some older sign icons with new icons.
  • Adds a unit test to ensure signs don't have extraneous or missing icon_states.
  • Ported many barsigns and several incidental Christmas item resprites from Polaris.

TODO:

  • Add missing types until all icon states are either in use or pruned.
  • Copy strings from Polaris signs or add new ones.

Why and what will this PR improve

Helps with mapping compatibility from Baylike forks.

Authorship

Sign icons and definitions are from https://github.com/PolarisSS13/Polaris, I'm not sure of individual provenance. I believe a lot of them have been ported in turn from /tg/ or Paradise.

Changelog

Nothing player-facing.

@MistakeNot4892 MistakeNot4892 added the work in progress This PR is under development and shouldn't be merged. label Nov 26, 2025
@MistakeNot4892 MistakeNot4892 force-pushed the feature/moresigns branch 2 times, most recently from 8152cc2 to 8619e16 Compare November 26, 2025 08:12
@MistakeNot4892 MistakeNot4892 changed the title Adds many signs from Polaris. [IDB IGNORE] Adds many signs from Polaris. Nov 26, 2025
@MistakeNot4892 MistakeNot4892 force-pushed the feature/moresigns branch 12 times, most recently from 42f7c5a to 746a96e Compare November 27, 2025 02:39
@MistakeNot4892 MistakeNot4892 added ready for review This PR is ready for review and merge. and removed work in progress This PR is under development and shouldn't be merged. labels Nov 27, 2025
@MistakeNot4892 MistakeNot4892 marked this pull request as ready for review November 27, 2025 02:39
@MistakeNot4892 MistakeNot4892 changed the title [IDB IGNORE] Adds many signs from Polaris. Adds many signs from Polaris. Nov 27, 2025
desc = "A clumpy area of rust."
icon_state = "rusted"

/obj/structure/sign/floornums
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are these distinct from /obj/structure/sign/deck?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, these are numbers on the floor, not numbers indicating a floor. They should really be a floor decal not a sign, but :effort:

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh so these are all non-sign signs D: do they interact okay with the like. offsets?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly I haven't tested them. I am probably going to just make them floor decals when I find the spoons.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@MistakeNot4892 MistakeNot4892 added awaiting author This PR is awaiting action from the author before it can be merged. and removed ready for review This PR is ready for review and merge. labels Dec 26, 2025
@MistakeNot4892 MistakeNot4892 force-pushed the feature/moresigns branch 3 times, most recently from 3ae5ccf to f31626d Compare January 3, 2026 03:59
…gn icons.

Porting the Christmas gift and cracker icons from Polaris.

Ported several barsign icons from Polaris.
@MistakeNot4892 MistakeNot4892 removed the awaiting author This PR is awaiting action from the author before it can be merged. label Jan 3, 2026
@MistakeNot4892 MistakeNot4892 added the ready for review This PR is ready for review and merge. label Jan 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready for review This PR is ready for review and merge.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants