Make power debug machines not use the power subtype #5230
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
out-of-phaze
added
the
awaiting author
out-of-phaze
changed the title
out-of-phaze
force-pushed
the
codequality/debug-power
branch
from
fbd71e3 to
cbca446
Compare
out-of-phaze
added
ready for review
| @@ -0,0 +1,2 @@ | |||
| /obj/machinery/power/debug_items/@SUBTYPES : /obj/machinery/debug_items/@SUBTYPES{@OLD} | |||
| /obj/machinery/power/ascent_reactor/@SUBTYPES : /obj/machinery/power/@SUBTYPES{@OLD} No newline at end of file | |||
Contributor
There was a problem hiding this comment.
This doesn't seem correct.
MistakeNot4892
requested changes
Dec 30, 2025
Contributor
MistakeNot4892
left a comment
MistakeNot4892
left a comment
There was a problem hiding this comment.
Migration is using the wrong replacement path.
out-of-phaze
force-pushed
the
codequality/debug-power
branch
from
cbca446 to
b4f6be0
Compare
MistakeNot4892
approved these changes
Dec 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Split out of #5120.
Power debug objects are no longer a
/obj/machinery/powersubtype because, well, they don't need to be.Why and what will this PR improve
Unnecessary subtyping is unnecessary.
Authorship
Me