Skip to content

Conversation

@SoongNoonien
Copy link
Collaborator

This addresses #1207. Right now base_ring and coefficient_ring seem to be completely equivalent but with #2182 this will change. Depending on the merge order I can adjust this or the other PR to include an example (with universal polynomials) in the docs which clarifies the difference between base_ring and coefficient_ring.

@SoongNoonien SoongNoonien force-pushed the coeff_ring branch 2 times, most recently from 45d9da8 to 62a69f3 Compare October 9, 2025 14:20
@codecov
Copy link

codecov bot commented Oct 9, 2025

Codecov Report

❌ Patch coverage is 85.71429% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 87.96%. Comparing base (10cb1ce) to head (7dd8e29).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/generic/QuotientModule.jl 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2185      +/-   ##
==========================================
+ Coverage   87.93%   87.96%   +0.02%     
==========================================
  Files         127      127              
  Lines       31802    31805       +3     
==========================================
+ Hits        27964    27976      +12     
+ Misses       3838     3829       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@SoongNoonien SoongNoonien marked this pull request as draft October 9, 2025 15:23
@fingolfin
Copy link
Member

Thanks for starting this! BTW I think we can also do something like this for series rings

@SoongNoonien SoongNoonien changed the title Add coefficient_ring for modules and improve the docs for base_ring Add coefficient_ring for modules and series and improve the docs for base_ring Oct 17, 2025
@SoongNoonien SoongNoonien marked this pull request as ready for review October 17, 2025 10:03
@SoongNoonien
Copy link
Collaborator Author

Ok, I think we can merge this as it is now and resolve #2187 with a follow up and possibly breaking PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants