Skip to content

Make equality of factorizations give error (instead of false) #2188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 29, 2025
Merged

Make equality of factorizations give error (instead of false) #2188

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7e8619a
Make equality of factorizations give error (instead of false)
JohnAAbbott Oct 16, 2025
4f00952
Added basic test
JohnAAbbott Oct 20, 2025
4b8fa67
Equality test of factorizations ALWAYS gives error; updated tests
JohnAAbbott Oct 20, 2025
7f40048
Removed cruft
JohnAAbbott Oct 20, 2025
9d85021
Apply suggestions from code review
fingolfin Oct 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/Factor.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,10 @@ _is_legal(a::Fac) = xor(isdefined(a, :fac), isdefined(a, :arr))

_is_dic(a::Fac) = _is_legal(a) && isdefined(a, :fac)

function Base.:(==)(F1::Fac{T1}, F2::Fac{T2}) where {T1 <: RingElement, T2 <: RingElement}
error("Equality testing of factorizations is not supported");
end

@doc raw"""
unit(a::Fac{T}) -> T

Expand Down
9 changes: 9 additions & 0 deletions test/Factor-test.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,3 +29,12 @@ end
@test string(f) == "x * (x + y) * (x*y)" ||
string(f) == "x * (x*y) * (x + y)"
end

@testset "Fac.equality" begin
# 2025-10-20 equality test on factorizations always gives error (even if the args are ===)
f = Fac(-1, Dict{Int, Int}(2 => 3, 3 => 1))
ff = Fac(-1, [2 => 3, 3 => 1])

@test_throws ErrorException f == f
@test_throws ErrorException (f == ff)
end