Towards inplace iterators for exponents of multivariate polynomials etc. #2196
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an
inplaceoption to the iterators of exponents, coefficients, terms and monomials of a multivariate polynomial.This is still a draft. Is this the "interface" we want?
Regarding the new functions
coeff!,term!andexponent_vector!: Should they be exported (I did it for now becausemonomial!is exported as well)? Do I need to implement an "abstract fall-back" insrc/MPoly.jl?Nemocas/Nemo.jl#2161 implements the (few) necessary functions for
QQMPolyRingElem. Using those, I get the following timings in oscar-system/Oscar.jl#5483 :So that moves in the right direction.