Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
84 changes: 84 additions & 0 deletions packages/nextjs/taro/src/basics/eventCenter.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,84 @@
/**
* Taro事件中心代理类
* 实现客户端懒加载@tarojs/runtime中的eventCenter
* 解决从@tarojs/taro导入的eventCenter为空的问题
*/
import promisify from 'mpromisify'
import { limited } from '../_util'

// 单例实例
let instance: EventCenterProxy

interface EventCenterProxy {
ready: boolean
eventCenter: any
pendingCalls: any[]
Comment on lines +12 to +15
Copy link

Copilot AI Sep 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The interface uses 'any' types which reduces type safety. Consider defining more specific types for 'eventCenter' and 'pendingCalls' to improve code maintainability and catch potential runtime errors.

Suggested change
interface EventCenterProxy {
ready: boolean
eventCenter: any
pendingCalls: any[]
interface EventCenterMethods {
on: (...args: any[]) => any
off: (...args: any[]) => any
trigger: (...args: any[]) => any
once: (...args: any[]) => any
}
interface PendingCall {
method: keyof EventCenterMethods
args: any[]
resolve: (value: any) => void
reject: (reason?: any) => void
}
interface EventCenterProxy {
ready: boolean
eventCenter: EventCenterMethods | null
pendingCalls: PendingCall[]

Copilot uses AI. Check for mistakes.

}

class EventCenterProxy {
constructor() {
if (instance) {
return instance
}

this.ready = false
this.eventCenter = null
this.pendingCalls = []
// eslint-disable-next-line @typescript-eslint/no-this-alias
instance = this
}

// 获取单例实例
static getInstance() {
if (!instance) {
instance = new EventCenterProxy()
}
return instance
}

// 加载真实eventCenter
async loadEventCenter() {
Copy link

Copilot AI Sep 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The loadEventCenter method lacks protection against concurrent calls. If multiple methods are called simultaneously before the eventCenter is loaded, this could result in multiple import attempts. Consider adding a loading flag or using a singleton promise to prevent race conditions.

Copilot uses AI. Check for mistakes.

try {
const { eventCenter } = await import('@tarojs/runtime')
this.eventCenter = eventCenter
this.ready = true

// 执行所有待处理的调用
this.pendingCalls.forEach(({ method, args, resolve }) => {
resolve(this.eventCenter[method](...args))
})
this.pendingCalls = []
} catch (error) {
console.error('加载eventCenter失败:', error)
// 失败时也执行待处理调用,避免阻塞
this.pendingCalls.forEach(({ reject }) => reject(error))
this.pendingCalls = []
}
}

// 创建代理方法
createProxyMethod(method) {
Copy link

Copilot AI Sep 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The parameter 'method' should have a type annotation. Consider adding ': string' to specify the expected parameter type.

Suggested change
createProxyMethod(method) {
createProxyMethod(method: string) {

Copilot uses AI. Check for mistakes.

return (...args) => {
if (this.ready) {
return this.eventCenter[method](...args)
}

return new Promise((resolve, reject) => {
this.pendingCalls.push({ method, args, resolve, reject })
const loadEventCenter = promisify(
limited.async('loadEventCenter', this.loadEventCenter)
)
loadEventCenter() // 触发加载
Copy link

Copilot AI Sep 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The loadEventCenter promise is created but not awaited or handled. This could lead to unhandled promise rejections if the loading fails. Consider using 'loadEventCenter().catch(() => {})' or properly handling the promise.

Suggested change
loadEventCenter() // 触发加载
loadEventCenter().catch(() => {}) // 触发加载,避免未处理的promise拒绝

Copilot uses AI. Check for mistakes.

})
}
}

// 代理方法
on = this.createProxyMethod('on')
off = this.createProxyMethod('off')
trigger = this.createProxyMethod('trigger')
once = this.createProxyMethod('once')
}

// 导出代理类和单例实例
export const eventCenter = EventCenterProxy.getInstance()
1 change: 1 addition & 0 deletions packages/nextjs/taro/src/basics/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -20,3 +20,4 @@ export * from './system'
export * from './update'
export * from './debug'
export * from './performance'
export * from './eventCenter'
8 changes: 7 additions & 1 deletion packages/nextjs/taro/src/index.ts
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
// Taro API 的 Next.js 兼容实现
// 提供与 Taro 官方 API 完全一致的接口,但适配 Next.js 环境

import {
// debug
setEnableDebug,
Expand All @@ -11,7 +14,8 @@ import {
getAppAuthorizeSetting,
getSystemInfoSync,
getSystemInfoAsync,
getSystemInfo
getSystemInfo,
eventCenter
} from './basics'

import {
Expand Down Expand Up @@ -184,6 +188,7 @@ export {
getSystemInfoSync,
getSystemInfoAsync,
getSystemInfo,
eventCenter,

createOffscreenCanvas,
createCanvasContext,
Expand Down Expand Up @@ -323,6 +328,7 @@ export default {
getSystemInfoSync,
getSystemInfoAsync,
getSystemInfo,
eventCenter,

createOffscreenCanvas,
createCanvasContext,
Expand Down
Loading