Skip to content

Conversation

@EdwinBetanc0urt
Copy link

@EdwinBetanc0urt EdwinBetanc0urt commented Jul 25, 2025

Add DB_ENGINE environment variable, and unify alls DB_* redundant environment variables.

Additional context
The previous method of configuring databases still works, to provide backward compatibility, but priority is given to this proposed approach. In the future (in a major version), the previous method should be removed.

fixes #4677

Add `DB_ENGINE` environment variable, and unify alls `DB_*` redundant environment variables.
fixes NginxProxyManager#4677
```
/app/lib/config.js
   5:1   error  This group of assignments is not aligned   align-assignments/align-assignments
  14:9   error  Missing space before value for key 'host'  key-spacing
  15:9   error  Missing space before value for key 'port'  key-spacing
  19:9   error  Missing space before value for key 'host'  key-spacing
  20:9   error  Missing space before value for key 'port'  key-spacing
  24:9   error  Missing space before value for key 'host'  key-spacing
  25:9   error  Missing space before value for key 'port'  key-spacing
  30:2   error  Missing semicolon                          semi
  58:4   error  This group of assignments is not aligned   align-assignments/align-assignments
  58:62  error  Missing semicolon                          semi
  76:4   error  This group of assignments is not aligned   align-assignments/align-assignments
  76:62  error  Missing semicolon                          semi

✖ 12 problems (12 errors, 0 warnings)
  12 errors and 0 warnings potentially fixable with the `--fix` option.
```
```
/app/lib/config.js
  58:4  error  This group of assignments is not aligned  align-assignments/align-assignments
  76:4  error  This group of assignments is not aligned  align-assignments/align-assignments

✖ 2 problems (2 errors, 0 warnings)
  2 errors and 0 warnings potentially fixable with the `--fix` option.
```
@jc21 jc21 added the requires-verification Waiting for one or more people to confirm the fix label Aug 22, 2025
@nginxproxymanagerci
Copy link

CI Error:

/bin/bash: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8)
certbot-node: Pulling from nginxproxymanager/nginx-full
Digest: sha256:a3f685a6ec6c4a3781242888fbfa53127abec9321d7ae871486ed2246693cdc4
Status: Image is up to date for nginxproxymanager/nginx-full:certbot-node
docker.io/nginxproxymanager/nginx-full:certbot-node
�[1;34m❯ �[1;36mTesting backend ...�[0m
yarn install v1.22.22
[1/4] Resolving packages...
[2/4] Fetching packages...
warning lru.min@1.1.2: The engine "bun" appears to be invalid.
warning lru.min@1.1.2: The engine "deno" appears to be invalid.
[3/4] Linking dependencies...
warning " > @apidevtools/swagger-parser@10.1.1" has unmet peer dependency "openapi-types@>=7".
[4/4] Building fresh packages...
Done in 8.56s.
yarn run v1.22.22
$ biome lint .
lib/config.js:67:33 lint/correctness/noInvalidUseBeforeDeclaration ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

  × This variable is used before its declaration.
  
    65 │ 	if (envDataBaseEngne) {
    66 │ 		if (envDataBaseEngne === 'sqlite') {
  > 67 │ 			logger.info(`Using Sqlite: ${envSqliteFile}`);
       │ 			                             ^^^^^^^^^^^^^
    68 │ 			const defaultConection = dataBaseEngines[envDataBaseEngne];
    69 │ 			const envSqliteFile    = process.env.DB_SQLITE_FILE || '/data/database.sqlite';
  
  i The variable is declared here:
  
    67 │ 			logger.info(`Using Sqlite: ${envSqliteFile}`);
    68 │ 			const defaultConection = dataBaseEngines[envDataBaseEngne];
  > 69 │ 			const envSqliteFile    = process.env.DB_SQLITE_FILE || '/data/database.sqlite';
       │ 			      ^^^^^^^^^^^^^
    70 │ 			instance               = {
    71 │ 				database: {
  

Checked 83 files in 38ms. No fixes applied.
Found 1 error.
lint ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

  × Some errors were emitted while running checks.
  

info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
error Command failed with exit code 1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

requires-verification Waiting for one or more people to confirm the fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Standardize environment variables for database connection

2 participants