Skip to content

Split player.html into separate CSS and JS files #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
Copilot wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Split player.html into separate CSS and JS files #51

Copilot wants to merge 3 commits into from

Conversation

Copy link
Contributor

Copilot AI commented Oct 31, 2025 •
edited
Loading

Extracts inline styles and scripts from player.html into dedicated player.css and player.js files for improved maintainability while preserving the static, build-free architecture.

Changes

File structure:

  • player.css (24KB) — all application styles
  • player.js (94KB) — all application logic
  • player.html (7.5KB, down from ~130KB) — HTML structure with external references

Updated references in player.html:

<head>
  <title>Local MP3 Folder Player</title>
  <link rel="stylesheet" href="player.css">
</head>
<body>
  <!-- ... -->
  <script src="player.js"></script>
</body>

Documentation updates:

  • README.md — removed "all bundled into one file" language
  • AGENTS.md — updated project structure section
  • .github/copilot-instructions.md — updated architecture and file organization

Screenshot

Player UI unchanged, now loading from external assets:

Player after refactor

All functionality verified: controls, modals, persistence, and state management work as before. No build tooling introduced—app remains directly runnable in Chromium browsers.

Original prompt

This section details on the original issue you should resolve

<issue_title>Split player.html into separate JS and CSS files</issue_title>
<issue_description>## Summary
The single player.html file currently mixes HTML structure, embedded styles, and application logic. For maintainability and to align with our UI guidelines, let's extract the inline script and styles into dedicated .js and .css files while keeping the app functioning as a static build.

Tasks

  • Move the inline JavaScript into a new module (e.g. player.js) and update player.html to load it.
  • Move the inline styles into a new stylesheet (e.g. player.css) and reference it from player.html.
  • Ensure relative paths keep the project self-contained and offline-friendly.
  • Update the README with any new development or manual testing steps if needed.
  • Manually verify player functionality (folder selection, playback, persistence) in Chromium-based browsers.

Acceptance Criteria

  • player.html contains minimal markup with external references to the new JS and CSS assets.
  • The player loads and behaves exactly as before after the refactor.
  • README instructions remain accurate and up to date.
    </issue_description>

Comments on the Issue (you are @copilot in this section)

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI and others added 2 commits October 31, 2025 05:40
@paulpv
✨ Split player.html into separate CSS and JS files
687e839 
Co-authored-by: paulpv <1393897+paulpv@users.noreply.github.com>
@paulpv
📝 Update documentation for separated CSS and JS files
3410dd4 
Co-authored-by: paulpv <1393897+paulpv@users.noreply.github.com>
Copilot AI changed the title [WIP] Split player.html into separate JS and CSS files Split player.html into separate CSS and JS files Oct 31, 2025
Copilot AI requested a review from paulpv October 31, 2025 05:49
@paulpv paulpv force-pushed the main branch 6 times, most recently from 7411d7b to 0185e64 Compare November 3, 2025 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@paulpv paulpv Awaiting requested review from paulpv

Assignees

@paulpv paulpv

Copilot code review Copilot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Split player.html into separate JS and CSS files

2 participants

@paulpv