Skip to content

Only call describe regions if copy_to_regions is true #320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Only call describe regions if copy_to_regions is true #320

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions upload-ami/src/upload_ami/upload_ami.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -332,16 +332,17 @@ def upload_ami(
ec2, image_name, image_info, snapshot_id, public, enable_tpm
)

regions = filter(
lambda x: x.get("RegionName") != ec2.meta.region_name
and (True if dest_regions == [] else x.get("RegionName") in dest_regions),
ec2.describe_regions()["Regions"],
)


image_ids: dict[str, str] = {}
image_ids[ec2.meta.region_name] = image_id

if copy_to_regions:
regions = filter(
lambda x: x.get("RegionName") != ec2.meta.region_name
and (True if dest_regions == [] else x.get("RegionName") in dest_regions),
ec2.describe_regions()["Regions"],
)
image_ids.update(
copy_image_to_regions(
image_id, image_name, ec2.meta.region_name, regions, public
Expand Down