Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 46 additions & 0 deletions lib/api/ensureDir.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,46 @@
import { request } from '../tools/smb2-forge';
import Bluebird from 'bluebird';

const requestAsync = Bluebird.promisify(request);

const ensureOneDir = async function(path, connection) {
try {
const fileOrDir = await requestAsync('open', { path }, connection);
if (fileOrDir.FileAttributes.readIntBE(0, 1) === 0x00000010) {
// See http://download.microsoft.com/DOWNLOAD/9/5/E/95EF66AF-9026-4BB0-A41D-A4F81802D92C/[MS-FSCC].pdf Section 2.6
await requestAsync('close', fileOrDir, connection);
} else {
throw new Error(`${path} exists but is not a directory`);
}
} catch (err) {
if (err.code === 'STATUS_OBJECT_NAME_NOT_FOUND') {
try {
await requestAsync('create_folder', { path }, connection);
} catch (err) {
if (err.code !== 'STATUS_OBJECT_NAME_COLLISION') {
throw err;
}
}
} else {
throw err;
}
}
};

export default async function(path, cb) {
const structure = path.split('\\');
const base = [];
try {
while (structure.length) {
base.push(structure.shift());
const basePath = base.join('\\');
if (!basePath.length) {
continue;
}
await ensureOneDir(basePath, this);
}
cb(null);
} catch (error) {
cb(error);
}
}
2 changes: 1 addition & 1 deletion lib/api/writeFile.js
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ module.exports = function writeFile(filename, data, options, cb) {
function callback() {
return function(err) {
if (stop) return;
if (err) {
if (err && err.code !== 'STATUS_PENDING') {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand this change, what does this error mean and what should we do?

Should we resend this packet?

If not, how can we wait for this packet to be written?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAICT, this error only happens in case of async requests/responses which are not currently used in this library.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but smb2Client.createWriteStream is asynchronous, and I got this error.

cb && cb(err);
stop = true;
} else {
Expand Down
Loading