fix: project improvements and best practices #97
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix Go version: 1.24.0 → 1.23 (use stable release) - Add HEALTHCHECK to FastAPI Dockerfile for container self-healing - Remove duplicate httpx dependency from fastapi/requirements.txt - Add .dockerignore files to all reference apps (reduces image size) - Remove Cargo.lock from .gitignore (enables reproducible Rust builds) - Track Cargo.lock for rust reference app
golang.org/x/net@v0.47.0 requires go >= 1.24.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses several code quality and best practice issues identified during project analysis.
Changes
Critical Fixes:
1.24.0(unreleased) to1.23(stable LTS)httpx==0.28.1from fastapi/requirements.txtBuild Optimizations:
Added .dockerignore files to all 6 reference apps:
fastapi/- Python patternsfastapi-api-first/- Python patternsgolang/- Go patternsnodejs/- Node.js patternstypescript-api-first/- TypeScript/Node.js patternsrust/- Rust patternsThis reduces Docker build context size and speeds up builds.
Reproducible Builds:
Test plan