Implement Option to Disable Warning Log for Failed World Deletion #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous method parameter was not accessible
|
im wondering when this can be merged, as I am also in a case where it not deleting the folder isnt super important and this warning similarly clogs up my logs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an option to disable warning logging due to world deletion.
I frequently encounter a warning whenever I delete a world, cluttering my logs. I want to keep other warnings visible without adjusting my logging settings.
This change is somewhat niche, and it might overlook a potential issue where the folder is in use when
deleteDirectoryis called. However,forceDeleteOnExitmanages the folder appropriately on exit, so a failure may not be a major concern in a multitude of use cases.