Skip to content

main: higher schema coverage thresholds #4862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

main: higher schema coverage thresholds #4862

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions vitest.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,13 @@ export default defineConfig({
coverage: {
include: ["src/schemas/validation/**/*.yaml"],
thresholds: process.env.BASE !== "dev" ? {
statements: 99.42, // should be 100% but we are missing some tests
lines: 99.42, // should be 100% but we are missing some tests
functions: 92.58, // should be 100% but we are missing some tests
// branches: 56.77, // need to discuss whether we should check/increase this
statements: 100, // JSON Schema keywords
lines: 100,
// functions: 100, // subschemas, for example with `properties` - to be discussed
// branches: 56.77, // branch coverage isn't that useful
} : {}
},
forceRerunTriggers: ['**/scripts/**', '**/tests/**'],
testTimeout: 10000, // 10 seconds
testTimeout: 20000, // 20 seconds, sometimes needed on slower machines
},
})