-
Notifications
You must be signed in to change notification settings - Fork 9.1k
3.2 typos and minor editorial changes #4876
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ralfhandl
commented
Aug 16, 2025
- schema changes are included in this pull request
- schema changes are needed for this pull request but not done yet
- no schema changes are needed for this pull request
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ralfhandl I really, really appreciate your thorough read-through here. I have some minor quibbles and questions, but nothing major and nothing I feel so strongly about as to really dig in if other folks are fine with it.
@handrews Let's discuss your questions, please comment on the changes you don't fully agree with. |
Henry's remarks Update src/oas.md Better explanation for custom anchor Co-Authored-By: Lorna Jane Mitchell <github@lornajane.net>
I think most things are now fine. I replied to the markdownlint section header problem elsewhere
There's also just using a media type as a media type regardless of its position. But in all three cases, it should be in backticks, just possibly also in quotes. I think. Like this:
|
@mikekistler Could you please re-approve? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re-approving.