Skip to content

Conversation

ralfhandl
Copy link
Contributor

  • schema changes are included in this pull request
  • schema changes are needed for this pull request but not done yet
  • no schema changes are needed for this pull request

@ralfhandl ralfhandl added this to the v3.2.0 milestone Aug 16, 2025
@ralfhandl ralfhandl requested review from a team as code owners August 16, 2025 15:49
@ralfhandl ralfhandl added the editorial Wording and stylistic issues label Aug 16, 2025
mikekistler
mikekistler previously approved these changes Aug 16, 2025
Copy link
Contributor

@mikekistler mikekistler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@mikekistler mikekistler requested a review from a team August 16, 2025 19:04
Copy link
Member

@handrews handrews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ralfhandl I really, really appreciate your thorough read-through here. I have some minor quibbles and questions, but nothing major and nothing I feel so strongly about as to really dig in if other folks are fine with it.

@ralfhandl
Copy link
Contributor Author

@handrews Let's discuss your questions, please comment on the changes you don't fully agree with.

Henry's remarks

Update src/oas.md

Better explanation for custom anchor

Co-Authored-By: Lorna Jane Mitchell <github@lornajane.net>
@handrews
Copy link
Member

@ralfhandl

@handrews Let's discuss your questions, please comment on the changes you don't fully agree with.

I think most things are now fine. I replied to the markdownlint section header problem elsewhere

That depends whether the media type mentioned in the comment is a field name or a field value.

There's also just using a media type as a media type regardless of its position. But in all three cases, it should be in backticks, just possibly also in quotes. I think. Like this:

  • Field name: text/event-stream
  • Field value: "text/event-stream"
  • Media type, regardless of position (or position ambiguous): text/event-stream

@ralfhandl
Copy link
Contributor Author

@mikekistler Could you please re-approve?

Copy link
Contributor

@mikekistler mikekistler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approving.

@ralfhandl ralfhandl merged commit bf0d54a into OAI:v3.2-dev Aug 20, 2025
2 checks passed
@ralfhandl ralfhandl deleted the 3.2-typos branch August 20, 2025 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editorial Wording and stylistic issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants