Skip to content

[18.0][FIX] document_page: Don't change last history name and summary… #565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
diggy128 wants to merge 1 commit into
base: 18.0
Choose a base branch
from
Open

[18.0][FIX] document_page: Don't change last history name and summary… #565

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions document_page/models/document_page.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,15 +36,15 @@ class DocumentPage(models.Model):
draft_name = fields.Char(
string="Name",
help="Name for the changes made",
related="history_head.name",
readonly=False,
compute="_compute_content",
inverse="_inverse_content",
)

draft_summary = fields.Char(
string="Summary",
help="Describe the changes made",
related="history_head.summary",
readonly=False,
compute="_compute_content",
inverse="_inverse_content",
)

template = fields.Html(
Expand Down Expand Up @@ -135,12 +135,18 @@ def _compute_content(self):
for rec in self:
if rec.type == "category":
rec.content = rec._get_page_index(link=False)
rec.draft_name = False
rec.draft_summary = False
else:
if rec.history_head:
rec.content = rec.history_head.content
rec.draft_name = rec.history_head.name
rec.draft_summary = rec.history_head.summary
else:
# html widget's default, so it doesn't trigger ghost save
rec.content = self._HTML_WIDGET_DEFAULT_VALUE
rec.draft_name = False
rec.draft_summary = False

def _inverse_content(self):
for rec in self:
Expand Down