-
-
Notifications
You must be signed in to change notification settings - Fork 532
[17.0] mig queue job batch #788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 17.0
Are you sure you want to change the base?
[17.0] mig queue job batch #788
Conversation
[UPD] Update queue_job_batch.pot
standard migration and some little ux improvements: now hide button is a fa-check button that on click just marks as read the batch, do not navigate to it and updates immediately the systray.
* The batch enqueued method is removed, to better reflect the fact that the batch's jobs are executed immediately. * The batch state `draft` is is renamed to `pending`, for the same purpose. * The batch's `is_read` field is initialized as `False` (default value), and only set to `True` when it's actually read. * We now use `identity_exact` for the batch `check_state` delayed method. * The widget has been reimplemented due to the heavy refactoring made in the core `mail` app: odoo/odoo@7710c333
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: queue-18.0/queue-18.0-test_queue_job_batch Translate-URL: https://translation.odoo-community.org/projects/queue-18-0/queue-18-0-test_queue_job_batch/
[UPD] Update queue_job_batch.pot
* incorrect sintax in security rule * change missleading name of security rule
standard migration and some little ux improvements: now hide button is a fa-check button that on click just marks as read the batch, do not navigate to it and updates immediately the systray.
* The batch enqueued method is removed, to better reflect the fact that the batch's jobs are executed immediately. * The batch state `draft` is is renamed to `pending`, for the same purpose. * The batch's `is_read` field is initialized as `False` (default value), and only set to `True` when it's actually read. * We now use `identity_exact` for the batch `check_state` delayed method. * The widget has been reimplemented due to the heavy refactoring made in the core `mail` app: odoo/odoo@7710c333
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: queue-18.0/queue-18.0-queue_job_batch Translate-URL: https://translation.odoo-community.org/projects/queue-18-0/queue-18-0-queue_job_batch/
Currently translated at 100.0% (62 of 62 strings) Translation: queue-18.0/queue-18.0-queue_job_batch Translate-URL: https://translation.odoo-community.org/projects/queue-18-0/queue-18-0-queue_job_batch/it/
9665bc5 to
411eeb3
Compare
petrus-v
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far I understand v16.0 and version v18.0 has notifications system while queue_job.batch state changed. Is it desired to drop that support while migrate the module ?
|
This PR has the |
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
mostafabarmshory
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This addon accepted in both 18 and 16 but not in 17. Is there any issue? It could be merged with main branch.
|
Could you check this PR and merge with the main branch please? |
|
@barkat-matthias @petrus-v @StephaneMangin Dear guys this PR is ok and checked with other. Would you merge this with the branch 17.0, please? |
|
this RP needs merge command. Could you merge the RP with branch 17.0, please? |
|
@AnizR any chance we can merge this? It's been reviewed, CI is all green, so ready to go I think :) |
We are not allowed to merge this PR. I think it's better to ping @OCA/queue-maintainers team ! |
Migrate queue_job_batch et test_queue_job_batch