-
-
Notifications
You must be signed in to change notification settings - Fork 532
Increase ideal timeout value to 5 seconds. #812
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 18.0
Are you sure you want to change the base?
Conversation
It is good to increase ideal timeout value to 5 seconds to avoid any network latency related error/request failure.
|
Hi @guewen, |
amh-mw
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is good to increase ideal timeout value to 5 seconds to avoid any network latency related error/request failure.
Network latency? Isn't this request local to the current Odoo server? Or at least the local container cluster?
# we are not interested in the result, so we set a short timeout
# but not too short so we trap and log hard configuration errorsWhy wait longer for a response that is not desired?
Firstly, Yes, I am talking about local requests. Think about too much external requests that jammed or slow down the Server or Odoo instance or HTTP server processes; or, think about a scenario of Brute-force or DDoS and the request didn't get response on-time and exceeded 2-3 seconds. In these scenarios, even internal/local requests might fail. Secondly, in normal system operation, if no bottlenecks, of course the requests/response will be quick even less than a sec although you increase to 5 seconds. A bit timeout increase is a safe-side which will ensure quicker response in normal case as well as will ensure safety in high-load/stress scenario. It doesn't matter if the request is internal or external. One problem I have faced is, due to some internal Python + Odoo process + System process's misbehave, a lot of repeated, failed jobs were re-queued, timed-out due to unresponsiveness. |
|
I suspect your problem is due to an overload on the Odoo instances that process jobs with no workers available to accept new jobs. Please check that the root channel capacity is lower than the number of workers and that it leaves enough workers available for the interactive workload. Until there is more evidence, I'm -1 on changing this timeout. |
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
It is good to increase ideal timeout value to 5 seconds to avoid any network latency related error/request failure.