Skip to content

[15.0][ADD] web_hide_custom_search #1124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: 15.0
Choose a base branch
from
Open

[15.0][ADD] web_hide_custom_search #1124

wants to merge 1 commit into from

Conversation

AungKoKoLin1997
Copy link
Contributor

@AungKoKoLin1997 AungKoKoLin1997 commented Jul 16, 2025 •
edited
Loading

This module allows controlling the visibility of the “Add Custom Filter” and “Add Custom Group” options in the search view for specific models and specific user groups.

@qrtl QT4975

@AungKoKoLin1997 AungKoKoLin1997 force-pushed the 15.0-add-custom_filter_groupby_visibility_control branch from 8b96711 to 1570873 Compare July 16, 2025 05:58
@pedrobaeza pedrobaeza added this to the 15.0 milestone Jul 16, 2025
@pedrobaeza
Copy link
Member

Shouldn't it start with web_?

@AungKoKoLin1997 AungKoKoLin1997 force-pushed the 15.0-add-custom_filter_groupby_visibility_control branch from 1570873 to d2abed9 Compare July 16, 2025 08:30
@AungKoKoLin1997 AungKoKoLin1997 changed the title [15.0][ADD] custom_filter_groupby_visibility_control [15.0][ADD] web_custom_filter_groupby_visibility_control Jul 16, 2025
@AungKoKoLin1997 AungKoKoLin1997 force-pushed the 15.0-add-custom_filter_groupby_visibility_control branch 2 times, most recently from 2632ae1 to c9371c6 Compare July 16, 2025 10:34
@AungKoKoLin1997 AungKoKoLin1997 changed the title [15.0][ADD] web_custom_filter_groupby_visibility_control [15.0][ADD] web_hide_custom_filter Jul 16, 2025
@AungKoKoLin1997 AungKoKoLin1997 force-pushed the 15.0-add-custom_filter_groupby_visibility_control branch from c9371c6 to b6e3319 Compare July 16, 2025 10:39
yostashiro
yostashiro reviewed Jul 16, 2025
View reviewed changes
Copy link
Member

@yostashiro yostashiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Partial review.

Module name suggestion: web_hide_custom_search

Sorry, I just came to think that 'custom search' would cover both filter and group-by.

@AungKoKoLin1997 AungKoKoLin1997 force-pushed the 15.0-add-custom_filter_groupby_visibility_control branch 2 times, most recently from c382341 to 5476066 Compare July 17, 2025 02:22
yostashiro
yostashiro reviewed Jul 17, 2025
View reviewed changes
Copy link
Member

@yostashiro yostashiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM. Could we add tests?

@AungKoKoLin1997 AungKoKoLin1997 changed the title [15.0][ADD] web_hide_custom_filter [15.0][ADD] web_hide_custom_search Jul 17, 2025
@AungKoKoLin1997 AungKoKoLin1997 force-pushed the 15.0-add-custom_filter_groupby_visibility_control branch from 5476066 to 338b985 Compare July 17, 2025 07:32
@AungKoKoLin1997
Copy link
Contributor Author

Could we add tests?

@yostashiro Added some test cases.

yostashiro
yostashiro approved these changes Jul 22, 2025
View reviewed changes
Copy link
Member

@yostashiro yostashiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

kanda999
kanda999 approved these changes Jul 23, 2025
View reviewed changes
Copy link

@kanda999 kanda999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional test: it works as expected

@dreispt
Copy link
Member

dreispt commented Aug 22, 2025

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 15.0-ocabot-merge-pr-1124-by-dreispt-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Aug 22, 2025
@OCA-git-bot
Merge PR #1124 into 15.0
172447d 
Signed-off-by dreispt
@OCA-git-bot
Copy link
Contributor

@dreispt your merge command was aborted due to failed check(s), which you can inspect on this commit of 15.0-ocabot-merge-pr-1124-by-dreispt-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@AungKoKoLin1997
Copy link
Contributor Author

It seems that every test using self.start_tour fails in 15.0 for some reason. The same issue occurs in the e-commerce repo.
OCA/e-commerce#1103

@dreispt Do you have any idea related this issue?

kanda999
kanda999 suggested changes Aug 26, 2025
View reviewed changes
Copy link

@kanda999 kanda999 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I press the "+" button in pivot view, I will get the error.
This error comes from this module.

2025-08-26_13h48_52

@AungKoKoLin1997 AungKoKoLin1997 force-pushed the 15.0-add-custom_filter_groupby_visibility_control branch from 4a702ef to 8fc85fb Compare August 26, 2025 10:16
@AungKoKoLin1997
Copy link
Contributor Author

@kanda999 Fixed it. Please review.

@rvalyi
Copy link
Member

rvalyi commented Aug 27, 2025

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 15.0-ocabot-merge-pr-1124-by-rvalyi-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Aug 27, 2025
@OCA-git-bot
Merge PR #1124 into 15.0
d7d591c 
Signed-off-by rvalyi
@OCA-git-bot
Copy link
Contributor

@rvalyi your merge command was aborted due to failed check(s), which you can inspect on this commit of 15.0-ocabot-merge-pr-1124-by-rvalyi-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@AungKoKoLin1997
Copy link
Contributor Author

It seems that every test using self.start_tour fails in 15.0 for some reason. The same issue occurs in the e-commerce repo. OCA/e-commerce#1103

@dreispt Do you have any idea related this issue?

@rvalyi This issue still exists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yostashiro yostashiro Awaiting requested review from yostashiro

@dreispt dreispt Awaiting requested review from dreispt

1 more reviewer

@kanda999 kanda999 kanda999 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
approved
Projects
None yet
Milestone
15.0
Development

Successfully merging this pull request may close these issues.
7 participants
@AungKoKoLin1997 @pedrobaeza @dreispt @OCA-git-bot @rvalyi @yostashiro @kanda999